feat: download only yarn.js from npm
#439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you considered using |
aduh95
reviewed
Mar 25, 2024
aduh95
reviewed
Mar 25, 2024
aduh95
reviewed
Mar 25, 2024
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
reviewed
Mar 26, 2024
arcanis
reviewed
Mar 26, 2024
Co-authored-by: Maël Nison <[email protected]>
aduh95
reviewed
Mar 26, 2024
aduh95
reviewed
Mar 26, 2024
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
reviewed
Mar 26, 2024
aduh95
reviewed
Mar 26, 2024
|
Other than tests, is there something else to be done before this can be marked as ready for reviews? |
No, I think. But I'm experiencing some networking problems and have little time resolving it. So may be it will be ready in 1-2 days. |
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
reviewed
Mar 27, 2024
Co-authored-by: Antoine du Hamel <[email protected]>
aduh95
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
binproperty toNpmRegistrySpec. When installing yarn berry from custom registry, it'll only install the bin file and calculate hash of the bin file itself.Fix #435