Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update supported Node.js versions #258

Merged
merged 4 commits into from
May 19, 2023
Merged

chore: update supported Node.js versions #258

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
01d6a5f
chore: update supported Node.js versions
aduh95 Apr 18, 2023
fda2ead
fix build command
aduh95 Apr 19, 2023
44bb2c7
link to Node.js docs, clean up README
aduh95 Apr 19, 2023
cb92dce
Merge branch 'main' into nodejs-versions
aduh95 May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,9 @@ jobs:
fail-fast: false
matrix:
node:
- 14
- 16
- 18
- 20
platform:
- ubuntu-latest
- macos-latest
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/update-nock-files.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
with:
# Let's use the oldest version supported to be sure the V8
# serialization is compatible with all supported versions.
node-version: 14.x
node-version: 16.x

- name: Get the Yarn cache directory path
id: yarn-cache-dir-path
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ use npm.

### Default Installs

Corepack is distributed by default with Node.js 14.19.0 and 16.9.0, but is
Corepack is distributed by default with all recent Node.js versions, but is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer a specific version here because this is about the expectation of corepack cli being distributed with node in the current PATH.

Alternatively, we could link to the official docs that mention the versions in the first section:

Added in: v16.9.0, v14.19.0

opt-in for the time being. Run `corepack enable` to install the required shims.

### Manual Installs
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
"url": "https://github.com/nodejs/corepack.git"
},
"engines": {
"node": ">=14.14.0"
"node": ">=16.20.0"
},
"exports": {
"./package.json": "./package.json"
Expand Down