-
Notifications
You must be signed in to change notification settings - Fork 173
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Node.js segfaults when using `npm@>=9.7.0` and `v8-compile-cache` ```console $ docker run -it node:20.3.0-slim corepack [email protected] --version [SIGSEGV] ```
- Loading branch information
Showing
2 changed files
with
8 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -169,7 +169,7 @@ export async function installVersion(installTarget: string, locator: Locator, {s | |
/** | ||
* Loads the binary, taking control of the current process. | ||
*/ | ||
export async function runVersion(installSpec: { location: string, spec: PackageManagerSpec }, binName: string, args: Array<string>): Promise<void> { | ||
export async function runVersion(locator: Locator, installSpec: { location: string, spec: PackageManagerSpec }, binName: string, args: Array<string>): Promise<void> { | ||
let binPath: string | null = null; | ||
if (Array.isArray(installSpec.spec.bin)) { | ||
if (installSpec.spec.bin.some(bin => bin === binName)) { | ||
|
@@ -191,8 +191,12 @@ export async function runVersion(installSpec: { location: string, spec: PackageM | |
if (!binPath) | ||
throw new Error(`Assertion failed: Unable to locate path for bin '${binName}'`); | ||
|
||
// @ts-expect-error - No types | ||
await import(`v8-compile-cache`); | ||
// Node.js segfaults when using npm@>=9.7.0 and v8-compile-cache | ||
// $ docker run -it node:20.3.0-slim corepack [email protected] --version | ||
// [SIGSEGV] | ||
if (locator.name !== `npm` || semver.lt(locator.reference, `9.7.0`)) | ||
// @ts-expect-error - No types | ||
await import(`v8-compile-cache`); | ||
|
||
// We load the binary into the current process, | ||
// while making it think it was spawned. | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters