fix: support trailing slash

[RafaelGSS]

Refs: https://openjs-foundation.slack.com/archives/C019Y2T6STH/p1720463991463229

[RafaelGSS]

Not sure why lint is complaining... If I remove the \/? from Fixes, tests won't pass.

[Trott]

Not sure why lint is complaining... If I remove the \/? from Fixes, tests won't pass.

It's complaining because you're backslash-escaping it in a string. You don't need to backslash-escape a slash character in a string, only in a regex literal.

[Trott]

Looks good to me. I assume that since you're a releaser, you've taken into consideration whether this might break relevant tools like the changelog maker. (I don't imagine it would break those tools. I'm just mentioning it in case you or someone else who deals with that tooling more often might think otherwise or want to give it a bit more consideration/testing.)

[RafaelGSS]

I assume that since you're a releaser, you've taken into consideration whether this might break relevant tools like the changelog maker. (I don't imagine it would break those tools. I'm just mentioning it in case you or someone else who deals with that tooling more often might think otherwise or want to give it a bit more consideration/testing.)

Considering we are not dropping support but adding trailing slash support, it should not impact the existing release workflow or tools like changelog maker. But, I'll monitor it over the week.

[richardlau]

I think the one possible change in behavior might be branch-diff if the PR-URL in the commits being compared differed only in whether they ended in a slash or not (since they'd no longer match).

[RafaelGSS]

I think the one possible change in behavior might be branch-diff if the PR-URL in the commits being compared differed only in whether they ended in a slash or not (since they'd no longer match).

That's correct. Let me see this first.

[RafaelGSS]

Created nodejs/branch-diff#70