Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Add meeting minutes for 2017-11-30 #188

Merged
merged 2 commits into from
Dec 7, 2017
Merged

Add meeting minutes for 2017-11-30 #188

merged 2 commits into from
Dec 7, 2017

Conversation

bnb
Copy link
Contributor

@bnb bnb commented Dec 7, 2017

Creates the file in the repo for last week's meeting. Original source: https://docs.google.com/document/d/1V9hFrZ4q8nIZj8yMveipZ5PKqqwZHZGNV4uPR7QnJ1o/edit?usp=sharing

ghost

This comment was marked as off-topic.

@bnb
Copy link
Contributor Author

bnb commented Dec 7, 2017

@pup Updated, fixed a lot of styling. PTAL 🙏

ghost

This comment was marked as off-topic.

@ghost
Copy link

ghost commented Dec 7, 2017

oh yeah, should we put closes [meeting issue] when we submit meeting notes? sometimes we forget to close the meeting issue even after merging the notes, but this would do it automatically

@bnb
Copy link
Contributor Author

bnb commented Dec 7, 2017

@pup Yep! That's a great idea - I didn't actually know what the syntax was, but now I do. We should probably log that somewhere. Does it need to be in the actual commit message?

Going to merge this and close #179

@bnb bnb merged commit 6ec9223 into master Dec 7, 2017
@bnb bnb deleted the bnb/2017-11-30-minutes branch December 7, 2017 21:44
@ghost
Copy link

ghost commented Dec 7, 2017

@bnb iirc github added a feature where if you just type "closing [issue]", it'll auto-close it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant