Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookup: add debug #626

Merged
merged 2 commits into from
Dec 12, 2018
Merged

lookup: add debug #626

merged 2 commits into from
Dec 12, 2018

Conversation

targos
Copy link
Member

@targos targos commented Nov 24, 2018

Hard Requirements:

  • Module source code must be on Github.
  • Published versions must include a tag on Github
  • The test process must be executable with only the commands npm install && npm test or (yarn install && yarn test) using the tarball downloaded from the Github tag mentioned above
  • The tests pass on supported major release lines
  • The maintainers of the module remain responsive when there are problems
  • At least one module maintainer must be added to the lookup maintainers field

Soft Requirements:

  • The module must be actively used by the community OR
  • The module must be heavily depended on OR

@targos
Copy link
Member Author

targos commented Dec 11, 2018

@codecov-io

This comment has been minimized.

@targos
Copy link
Member Author

targos commented Dec 12, 2018

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@targos
Copy link
Member Author

targos commented Dec 12, 2018

I'm going to skip Windows. I can reproduce the failure with a local clone of the repo. Also IBM platforms because of PhantomJS.

skip IBM and win32
@targos targos merged commit 64c42d2 into master Dec 12, 2018
@targos targos deleted the lookup-debug branch December 12, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants