Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added markdown escapes for _*~\ #52

Merged
merged 1 commit into from
Mar 1, 2018
Merged

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Mar 1, 2018

Fixes: #47

@rvagg
Copy link
Member Author

rvagg commented Mar 1, 2018

Note that this doesn't depend on word boundaries. At least for GitHub it matters for some: test_test_ and test\test\ are fine, testtest testtest are not. Since it doesn't (and I'd assume other parsers) have a problem with extra unnecessary escaping then I think we should be fine going the extra mile.

ChALkeR

This comment was marked as off-topic.

ChALkeR

This comment was marked as off-topic.

@rvagg rvagg force-pushed the rvagg/more-markdown-escapes branch from 1352412 to 2b5a600 Compare March 1, 2018 08:16
@rvagg rvagg merged commit 2b5a600 into master Mar 1, 2018
@rvagg rvagg deleted the rvagg/more-markdown-escapes branch March 1, 2018 08:17
@ChALkeR
Copy link
Member

ChALkeR commented Mar 1, 2018

@rvagg Also, just noticed — what about backticks (`)? Escaping those won't harm, unless when in an inline code block — inside those, it doesn't help.

E.g.:

  • Raw: x y ` z
  • Escaped: ` x ` y ` z
  • Inside inline code block: \ x ` y ` z`

@rvagg
Copy link
Member Author

rvagg commented Mar 1, 2018

well.. for Node changelogs we've relied on backticks to render code things and it's actually pretty common. Check out the changelog for 9.7.0 that's about to go out (rendered with this latest version of changelog-maker btw so it has extra escapes for _'s): https://github.com/nodejs/node/blob/v9.7.0-proposal/doc/changelogs/CHANGELOG_V9.md#9.7.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants