Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github-bot: clone nodejs/node repository #531

Merged
merged 1 commit into from
Nov 16, 2016

Conversation

phillipj
Copy link
Member

These changes clones the nodejs/node repository required for the bot to automatically attempt backport of new PRs.

Refs nodejs/github-bot#90

/cc @nodejs/github-bot

These changes clones the nodejs/node repository required for the bot to
automatically attempt backport of new PRs.

Refs nodejs/github-bot#90
@Fishrock123
Copy link
Contributor

cc @nodejs/build

jbergstroem

This comment was marked as off-topic.

@phillipj
Copy link
Member Author

Thanks for reviewing! For some reason I'm struggling to get my local ansible test setup up-n-running, really want to figure out what's causing that and ofc do a test run locally before applying to any of our servers.

@phillipj
Copy link
Member Author

@Fishrock123 too reduce the time spent cloning the node repo, I pushed a change fetching only the last revision. Cloning the whole repo history didn't seem necessary to me. From the ansible docs:

Create a shallow clone with a history truncated to the specified number or revisions. The minimum possible value is 1, otherwise ignored.

You okey with that?

@Fishrock123
Copy link
Contributor

@phillipj It needs access to any vM.x-staging staging branches currently in use. Technically it doesn't need master.

@jbergstroem
Copy link
Member

By accessing staging stuff I reckon you'll be touching most of master. Might as well do a full checkout seeing how shallow clones will have issues traversing history.

@phillipj phillipj merged commit 98ebe06 into nodejs:master Nov 16, 2016
@phillipj phillipj deleted the gh-bot-clone-node-repo branch November 16, 2016 18:54
@phillipj
Copy link
Member Author

Thanks for your thoughts, decided to remove the shallow clone, and just clone the entire node repo.

This has been applied to the github-bot server in production.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants