-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible: install V8 build deps for Python 3 #3418
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came about because in trying to address nodejs/node#48728 by updating 12:43:45 + ../../tools/v8/fetch_deps.py .
12:43:45 Cloning into '/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools'...
12:43:54 Traceback (most recent call last):
12:43:54 File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gclient.py", line 108, in <module>
12:43:54 import gclient_scm
12:43:54 File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gclient_scm.py", line 29, in <module>
12:43:54 import gerrit_util
12:43:54 File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gerrit_util.py", line 16, in <module>
12:43:54 import httplib2
12:43:54 ModuleNotFoundError: No module named 'httplib2'
12:43:54 Checking out depot_tools.
12:43:54 Traceback (most recent call last):
12:43:54 File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/../../tools/v8/fetch_deps.py", line 100, in <module>
12:43:54 FetchDeps(sys.argv[1])
12:43:54 File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/../../tools/v8/fetch_deps.py", line 72, in FetchDeps
12:43:54 depot_tools = node_common.EnsureDepotTools(v8_path, True)
12:43:54 File "/home/iojs/build/workspace/node-test-commit-v8-linux/tools/v8/node_common.py", line 40, in EnsureDepotTools
12:43:54 depot_tools = _Get(v8_path)
12:43:54 File "/home/iojs/build/workspace/node-test-commit-v8-linux/tools/v8/node_common.py", line 35, in _Get
12:43:54 subprocess.check_output(
12:43:54 File "/usr/lib64/python3.9/subprocess.py", line 424, in check_output
12:43:54 return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
12:43:54 File "/usr/lib64/python3.9/subprocess.py", line 528, in run
12:43:54 raise CalledProcessError(retcode, process.args,
12:43:54 subprocess.CalledProcessError: Command '['/usr/bin/python3', '/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gclient.py', 'metrics', '--opt-out']' returned non-zero exit status 1.
12:43:54 make: *** [Makefile:303: v8] Error 1 12:43:29 + ../../tools/v8/fetch_deps.py .
12:43:29 Cloning into '/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools'...
12:43:37 Traceback (most recent call last):
12:43:37 File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gclient.py", line 108, in <module>
12:43:37 import gclient_scm
12:43:37 File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gclient_scm.py", line 29, in <module>
12:43:37 import gerrit_util
12:43:37 File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gerrit_util.py", line 37, in <module>
12:43:37 from six.moves import urllib
12:43:37 ModuleNotFoundError: No module named 'six'
12:43:37 Checking out depot_tools.
12:43:37 Traceback (most recent call last):
12:43:37 File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/../../tools/v8/fetch_deps.py", line 100, in <module>
12:43:37 FetchDeps(sys.argv[1])
12:43:37 File "/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/../../tools/v8/fetch_deps.py", line 72, in FetchDeps
12:43:37 depot_tools = node_common.EnsureDepotTools(v8_path, True)
12:43:37 File "/home/iojs/build/workspace/node-test-commit-v8-linux/tools/v8/node_common.py", line 40, in EnsureDepotTools
12:43:37 depot_tools = _Get(v8_path)
12:43:37 File "/home/iojs/build/workspace/node-test-commit-v8-linux/tools/v8/node_common.py", line 35, in _Get
12:43:37 subprocess.check_output(
12:43:37 File "/usr/lib64/python3.9/subprocess.py", line 424, in check_output
12:43:37 return run(*popenargs, stdout=PIPE, timeout=timeout, check=True,
12:43:37 File "/usr/lib64/python3.9/subprocess.py", line 528, in run
12:43:37 raise CalledProcessError(retcode, process.args,
12:43:37 subprocess.CalledProcessError: Command '['/usr/bin/python3', '/home/iojs/build/workspace/node-test-commit-v8-linux/deps/v8/_depot_tools/gclient.py', 'metrics', '--opt-out']' returned non-zero exit status 1.
12:43:37 make: *** [Makefile:303: v8] Error 1 |
Ensure `httplib2` and `six` modules are installed for Python 3 on machines with the `build-test-v8` role.
targos
approved these changes
Jul 11, 2023
UlisesGascon
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure
httplib2
andsix
modules are installed for Python 3 on machines with thebuild-test-v8
role.Refs: nodejs/node#48728
Refs: nodejs/node#48710 (comment)