-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible: add httplib2 #2881
ansible: add httplib2 #2881
Conversation
This proved to be very tricky on the RHEL 7 s390x (LinuxONE) instances. $ sudo pip2 install httplib2
DEPRECATION: Python 2.7 reached the end of its life on January 1st, 2020. Please upgrade your Python as Python 2.7 is no longer maintained. pip 21.0 will drop support for Python 2.7 in January 2021. More details about Python 2 support in pip can be found at https://pip.pypa.io/en/latest/development/release-process/#python-2-support pip 21.0 will remove support for this functionality.
Collecting httplib2
Using cached httplib2-0.20.4.tar.gz (349 kB)
Installing build dependencies ... done
Getting requirements to build wheel ... error
ERROR: Command errored out with exit status 1:
command: /bin/python /usr/lib/python2.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpbgjji9
cwd: /tmp/pip-install-JBiOqF/httplib2
Complete output (4 lines):
Traceback (most recent call last):
File "/usr/lib/python2.7/site-packages/pip/_vendor/pep517/_in_process.py", line 15, in <module>
from glob import glob
ImportError: No module named glob
----------------------------------------
ERROR: Command errored out with exit status 1: /bin/python /usr/lib/python2.7/site-packages/pip/_vendor/pep517/_in_process.py get_requires_for_build_wheel /tmp/tmpbgjji9 Check the logs for full command output. I even tried And to cap everything off the |
# Required for V8 builds | ||
- name: rhel8 | update python package alternatives | ||
community.general.alternatives: | ||
link: /usr/bin/python | ||
name: python | ||
path: /usr/bin/python2 | ||
when: | ||
- os == "rhel8" | ||
- build_test_v8|default(False) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to ansible/roles/build-test-v8/tasks/partials/rhel8.yml
.
rhel8_s390x: [ | ||
'GConf2-devel,python2' # Needed for V8 builds | ||
], | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moved to ansible/roles/build-test-v8/tasks/partials/rhel8.yml
.
Maybe the tools are now able to run with Python 3? |
We'd still need to be able to run the job against older Node.js release lines. |
V8's `gclient.py` now requires `httplib2`. Install it on all the machines that the V8 CI can run on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
V8's
gclient.py
now requireshttplib2
. Install it on all themachines that the V8 CI can run on.
Fixes: #2880