Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup: add cross compiling machine #244

Merged
merged 3 commits into from
Dec 7, 2017

Conversation

joaocgreis
Copy link
Member

Currently supports Raspberry Pi 1. Based on Ubuntu 14.04.

Currently supports Raspberry Pi 1. Based on Ubuntu 14.04.
@joaocgreis
Copy link
Member Author

joaocgreis commented Nov 10, 2015

  • grep -q ^github.com ~/.ssh/known_hosts || (ssh-keyscan -t rsa github.com >> ~/.ssh/known_hosts)

EDIT: Part of the Jenkins script.

Because of v8:
deps/v8/src/base/build_config.h:156:2: error: #error Target architecture arm is only supported on arm and ia32 host
@joaocgreis
Copy link
Member Author

@nodejs/build any objections to just landing this? This has been working well enough for 2 years and should be in master. There can probably be improvements, but those can be done in other PRs.

gibfahn

This comment was marked as off-topic.

@gibfahn
Copy link
Member

gibfahn commented Dec 7, 2017

Let's just land it

@joaocgreis joaocgreis merged commit b942ce3 into nodejs:master Dec 7, 2017
seishun

This comment was marked as off-topic.

seishun

This comment was marked as off-topic.

seishun

This comment was marked as off-topic.

@joaocgreis
Copy link
Member Author

@seishun all of those seem to have the same root cause. These scripts were developed for Ansible 1, and worked well at the time. Ansible 2 seems to have changed things: ansible/ansible@2e39661

The variables are defined in ansible-vars.yaml. The solution seems simple, just change with_items: packages to with_items: "{{packages}}". The steps for ssh keys can be removed because we now use a shared key (that is already on the machine).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants