Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ansible: update for new jenkins-workspace machine #1054

Merged
merged 1 commit into from
Dec 31, 2017

Conversation

maclover7
Copy link
Contributor

cc @rvagg, this broke because of new jenkins workspace machine being added

@rvagg
Copy link
Member

rvagg commented Dec 31, 2017

yoik! thanks for picking this up

@rvagg rvagg merged commit 6576a6f into nodejs:master Dec 31, 2017
@maclover7 maclover7 deleted the jm-new-ip branch December 31, 2017 22:40
@maclover7
Copy link
Contributor Author

@rvagg Would you be able to run the ansible job for github-bot? I don't think I have machine access

@rvagg
Copy link
Member

rvagg commented Dec 31, 2017

I just did it manually, I'm not confident about the script and haven't run this particular one before so I've edited the environment file and changed that last line and restarted the service. Could you confirm it's working?

@maclover7
Copy link
Contributor Author

@rvagg yep, looks to be working again. Thank you for your help!

maclover7 added a commit to maclover7/build that referenced this pull request Dec 31, 2017
Been doing a bunch of work on the bot related to pull request status
lights, and would be helpful to have elevated permissions. For example,
Ansible permissions were needed to roll out
nodejs#1054.
maclover7 added a commit to maclover7/build that referenced this pull request Dec 31, 2017
Been doing a bunch of work on the bot related to pull request status
lights, and would be helpful to have elevated permissions. For example,
Ansible permissions were needed to roll out
nodejs#1054.
joyeecheung pushed a commit that referenced this pull request Jan 2, 2018
Been doing a bunch of work on the bot related to pull request status
lights, and would be helpful to have elevated permissions. For example,
Ansible permissions were needed to roll out
#1054.

PR-URL: #1056
Reviewed-By: Joyee Cheung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants