-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload dist assets to a staging R2 bucket before a release is promoted #3602
Comments
I suggest doing this between the "upload to DO" and "touch .done file" steps in the existing scripts (present in nodejs/node's Makefile and vcbuild.bat files). We can do the upload from the DO server via SSH. |
I created the |
It will be easier to do it from the DO server, as the releaser already has access to it and already copies the shasums to it. |
Sounds like a good way to go. see #3501 - I already started implementing the part of uploading the release artifacts to R2 |
Pr opened here in the node repo to copy both release assets and the signed shasum files to the staging R2 bucket: nodejs/node#51394 |
Note: nodejs/node#51394 should land before this does Reference nodejs#3602
Note: nodejs/node#51394 should land before this does Reference nodejs#3602
Note: nodejs/node#51394 should land before this does Reference nodejs#3602
PR to promote release assets from staging r2 bucket is merged in #3620 What are the next steps for this issue? |
Nightly build was promoted from the looks of it! https://r2.nodejs.org/download/nightly/v23.0.0-nightly2024070366b76e24e2/ There is a weird thing with the dates going on in the directory listing, but should be an easy fix. Will take a look later. |
For anyone unfamiliar with what we're trying to do with the R2 migration, see #3461
Due to some issues we've experienced with syncing release assets from the DO server to the
dist-prod
R2 bucket, we want to look into having adist-staging
R2 bucket that will have the assets before the release is promoted. What we think the issue is is that the DO server simply doesn't have enough resources to handle all of the traffic that comes after a release and handle uploading assets to the prod R2 bucket at the same time. By uploading to a staging bucket before the release is promoted (and thus before cache is purged), we should be able to solve this issue.Note this will not replace uploading the release assets to the DO server. The assets will still be uploaded there like usual.
TODO:
dist-staging
bucket on Node.js's Cloudflare accountdist-staging
bucket as soon as they're uploaded to the DO serverdist-staging
todist-prod
instead of from the dist folder in the DO server.cc @MoLow @ovflowd
The text was updated successfully, but these errors were encountered: