Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: import-in-the-middle release token #902

Merged
merged 3 commits into from
Jul 30, 2024
Merged

doc: import-in-the-middle release token #902

merged 3 commits into from
Jul 30, 2024

Conversation

legendecas
Copy link
Member

@legendecas legendecas commented Jul 23, 2024 •
edited
Loading

The requested token should have the following permissions:

permissions:
  contents: write
  pull-requests: write

https://github.com/googleapis/release-please-action?tab=readme-ov-file#workflow-permissions

/cc @mhdawson the repo has already a token configured with my personal token. please feel free to replace it with @nodejs-github-bot's one.

@legendecas legendecas force-pushed the expiration branch 2 times, most recently from c480f80 to 56a37ca Compare July 23, 2024 20:08
mhdawson
mhdawson approved these changes Jul 23, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

Created the token as the original request was already approved and added to the repo.

aduh95
aduh95 reviewed Jul 24, 2024
View reviewed changes
request-an-access-token.md Outdated Show resolved Hide resolved
@legendecas legendecas mentioned this pull request Jul 29, 2024
Closed
@legendecas
Copy link
Member Author

Added a missing step found in nodejs/import-in-the-middle#150 to grant @nodejs-github-bot write access on the repo if necessary.

mhdawson
mhdawson approved these changes Jul 30, 2024
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas merged commit 0acfbba into nodejs:main Jul 30, 2024
@legendecas legendecas deleted the expiration branch July 30, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 left review comments

@mhdawson mhdawson mhdawson approved these changes

@richardlau richardlau richardlau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legendecas @mhdawson @richardlau @aduh95