Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Focus on AsyncWorker, there are a number of issues/problems we should work through #353

Closed
mhdawson opened this issue Oct 18, 2018 · 2 comments
Closed

Focus on AsyncWorker, there are a number of issues/problems we should work through #353

mhdawson opened this issue Oct 18, 2018 · 2 comments
Milestone
Milestone 11

Comments

@mhdawson
Copy link
Member

No description provided.

@mhdawson mhdawson added this to the Milestone 11 milestone Oct 18, 2018
@mhdawson
Copy link
Member Author

nodejs/node-addon-api#231

gabrielschulhof pushed a commit to gabrielschulhof/node-addon-api that referenced this issue Dec 13, 2018
src: add AsyncWorker destruction suppression
d1e9315 
Add method `SuppressDestruct()` to `AsyncWorker`, which will cause an
instance of the class to remain allocated even after the `OnOK`
callback fires. Such an instance must be explicitly `delete`-ed from
user code.

Re: nodejs#231
Re: nodejs/abi-stable-node#353
@gabrielschulhof gabrielschulhof mentioned this issue Dec 13, 2018
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node-addon-api that referenced this issue Feb 13, 2019
src: add AsyncWorker destruction suppression
7679068 
Add method `SuppressDestruct()` to `AsyncWorker`, which will cause an
instance of the class to remain allocated even after the `OnOK`
callback fires. Such an instance must be explicitly `delete`-ed from
user code.

Re: nodejs#231
Re: nodejs/abi-stable-node#353
gabrielschulhof pushed a commit to gabrielschulhof/node-addon-api that referenced this issue Feb 13, 2019
src: add AsyncWorker destruction suppression
3b3a482 
Add method `SuppressDestruct()` to `AsyncWorker`, which will cause an
instance of the class to remain allocated even after the `OnOK`
callback fires. Such an instance must be explicitly `delete`-ed from
user code.

Re: nodejs#231
Re: nodejs/abi-stable-node#353
gabrielschulhof pushed a commit to gabrielschulhof/node-addon-api that referenced this issue Feb 13, 2019
src: add AsyncWorker destruction suppression
1cdfc87 
Add method `SuppressDestruct()` to `AsyncWorker`, which will cause an
instance of the class to remain allocated even after the `OnOK`
callback fires. Such an instance must be explicitly `delete`-ed from
user code.

Re: nodejs#231
Re: nodejs/abi-stable-node#353
mhdawson pushed a commit to nodejs/node-addon-api that referenced this issue Mar 20, 2019
@mhdawson
src: add AsyncWorker destruction suppression
b0f6b60 
Add method `SuppressDestruct()` to `AsyncWorker`, which will cause an
instance of the class to remain allocated even after the `OnOK`
callback fires. Such an instance must be explicitly `delete`-ed from
user code.

Re: #231
Re: nodejs/abi-stable-node#353

PR-URL: #407
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
@mhdawson
Copy link
Member Author

Closed via nodejs/node-addon-api#231

kevindavies8 added a commit to kevindavies8/node-addon-api-Develop that referenced this issue Aug 24, 2022
@kevindavies8
src: add AsyncWorker destruction suppression
80c00a5 
Add method `SuppressDestruct()` to `AsyncWorker`, which will cause an
instance of the class to remain allocated even after the `OnOK`
callback fires. Such an instance must be explicitly `delete`-ed from
user code.

Re: nodejs/node-addon-api#231
Re: nodejs/abi-stable-node#353

PR-URL: nodejs/node-addon-api#407
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
Marlyfleitas added a commit to Marlyfleitas/node-api-addon-Development that referenced this issue Aug 26, 2022
@Marlyfleitas
src: add AsyncWorker destruction suppression
52d4929 
Add method `SuppressDestruct()` to `AsyncWorker`, which will cause an
instance of the class to remain allocated even after the `OnOK`
callback fires. Such an instance must be explicitly `delete`-ed from
user code.

Re: nodejs/node-addon-api#231
Re: nodejs/abi-stable-node#353

PR-URL: nodejs/node-addon-api#407
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
wroy7860 added a commit to wroy7860/addon-api-benchmark-node that referenced this issue Sep 19, 2022
@wroy7860
src: add AsyncWorker destruction suppression
d29b780 
Add method `SuppressDestruct()` to `AsyncWorker`, which will cause an
instance of the class to remain allocated even after the `OnOK`
callback fires. Such an instance must be explicitly `delete`-ed from
user code.

Re: nodejs/node-addon-api#231
Re: nodejs/abi-stable-node#353

PR-URL: nodejs/node-addon-api#407
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
johnfrench3 pushed a commit to johnfrench3/node-addon-api-git that referenced this issue Aug 11, 2023
src: add AsyncWorker destruction suppression
e50e3c8 
Add method `SuppressDestruct()` to `AsyncWorker`, which will cause an
instance of the class to remain allocated even after the `OnOK`
callback fires. Such an instance must be explicitly `delete`-ed from
user code.

Re: nodejs/node-addon-api#231
Re: nodejs/abi-stable-node#353

PR-URL: nodejs/node-addon-api#407
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: NickNaso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Milestone 11
Development

No branches or pull requests
1 participant
@mhdawson