Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: remove confusing wording regarding NAN #398

Merged
merged 2 commits into from
Dec 13, 2018
Merged

Conversation

targos
Copy link
Member

@targos targos commented Dec 8, 2018

Use "Active LTS" instead.

Fixes: #147

Use "Active LTS" instead.

Fixes: #147
@richardlau
Copy link
Member

We already use "active" as separate from "maintenance".

@targos
Copy link
Member Author

targos commented Dec 8, 2018

@richardlau yes, and that's what it is about here.

@richardlau
Copy link
Member

We would expect the abstraction layer to also support maintenance releases.

@richardlau
Copy link
Member

Based on #359 maybe use "supported" instead?

@targos
Copy link
Member Author

targos commented Dec 8, 2018

But the next sentence says a maximum of 2 LTS releases. If maintenance was included it would be 3.

@richardlau
Copy link
Member

Hmm. You're right but I'd certainly be very surprised if I was using maintenance LTS and nan dropped support for it before it went EOL.

@MylesBorins
Copy link
Contributor

I think that this is a mistake... I do not believe that nan plans to remove support for a version of node that is supported by node

/cc @nodejs/n-api

@targos
Copy link
Member Author

targos commented Dec 11, 2018

I thought about it... My conclusion is that we can remove this section. NAN is out of the scope of the Release WG.

@targos
Copy link
Member Author

targos commented Dec 13, 2018

/cc @nodejs/release

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins changed the title doc: remove confusing wording of "current LTS" doc: remove confusing wording regarding NAN Dec 13, 2018
@MylesBorins
Copy link
Contributor

I've updated the title to better reflect the content. Landing

@MylesBorins MylesBorins merged commit 57070bc into master Dec 13, 2018
@targos targos deleted the targos-patch-2 branch December 13, 2018 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants