Website fundamental #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 46 out of 61 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- .editorconfig: Language not supported
- .gitattributes: Language not supported
- .nvmrc: Language not supported
- .vscode/extensions.json: Language not supported
- .vscode/settings.json: Language not supported
- app/article/[[...categories]]/page.module.css: Language not supported
- app/article/post/[article]/page.module.css: Language not supported
- biome.jsonc: Language not supported
- components/Common/AuthorsList/index.module.css: Language not supported
- components/Common/Avatar/index.module.css: Language not supported
- README.md: Evaluated as low risk
- TODO.md: Evaluated as low risk
- app/page.tsx: Evaluated as low risk
- components/Common/AuthorsList/index.tsx: Evaluated as low risk
- app/layout.tsx: Evaluated as low risk
Comments suppressed due to low confidence (2)
app/article/[[...categories]]/page.tsx:7
- The type name 'categoriesParams' should be capitalized to 'CategoriesParams' to maintain consistency.
type categoriesParams = {
app/article/[[...categories]]/page.tsx:11
- The type name 'PageProps' should be capitalized to 'PageProps' to maintain consistency.
type PageProps = {
AugustinMauroy
force-pushed
the
website-fundamental
branch
from
2f3b511 to
fc50088
Compare
AugustinMauroy
force-pushed
the
website-fundamental
branch
from
fc50088 to
13dd723
Compare
TODO.md
Outdated
There was a problem hiding this comment.
I think better to set up a basic project: https://github.com/nodejs-loaders/nodejs-loaders.github.io/projects
There was a problem hiding this comment.
IMO I should write issue after this pr got merge
There was a problem hiding this comment.
Could do. Issues seemed like more work.
Co-Authored-By: Jacob Smith <[email protected]>
Co-Authored-By: Jacob Smith <[email protected]>
Co-Authored-By: Jacob Smith <[email protected]>
There was a problem hiding this comment.
Copilot reviewed 52 out of 67 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- .editorconfig: Language not supported
- .gitattributes: Language not supported
- .nvmrc: Language not supported
- .vscode/extensions.json: Language not supported
- .vscode/settings.json: Language not supported
- app/article/[[...categories]]/page.module.css: Language not supported
- app/article/post/[article]/page.module.css: Language not supported
- biome.jsonc: Language not supported
- components/Common/AuthorsList/index.module.css: Language not supported
- components/Common/Avatar/index.module.css: Language not supported
- .github/workflows/deploy.yaml: Evaluated as low risk
- README.md: Evaluated as low risk
- TODO.md: Evaluated as low risk
- app/article/[[...categories]]/page.tsx: Evaluated as low risk
- app/article/post/[article]/page.tsx: Evaluated as low risk
JakobJingleheimer
approved these changes
Jan 30, 2025
|
Jacob agree with design ? |
|
Is it deployed somewhere? |
Sadly not for moment just have to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to get a preview:
nvm useorfvm use2
npm inode --run previewBack to #1
packagespage will not happen now. Because NPM registry doesn't want to give use our data.aboutpage just joined article aswhat-is-nodejs-loaders.mdx