Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clarification on Width units #63

Merged
merged 5 commits into from
Oct 13, 2018
Merged

Added clarification on Width units #63

merged 5 commits into from
Oct 13, 2018

Conversation

TreZc0
Copy link
Contributor

@TreZc0 TreZc0 commented Jul 15, 2018

This should be sufficient to allow users to get an idea of the width units.
A note could be added that these settings can easily be adjusted in the package.json afterwards.
resolves #58

This should be sufficient to allow users to get an idea of the width units.
A note could be added that these settings can easily be adjusted in the package.json afterwards.
@Hoishin
Copy link
Member

Hoishin commented Jul 15, 2018

Can't tell if it's better to write 16 + 144n.... 🙄

@TreZc0
Copy link
Contributor Author

TreZc0 commented Jul 15, 2018

144n - 16 right? Should be the same result and probably the least confusing math equation.

@Hoishin
Copy link
Member

Hoishin commented Oct 10, 2018

@TreZc0 I think it's been enough to merge this :P If you have time, would you mind pulling master branch and maybe update the equation?

@TreZc0
Copy link
Contributor Author

TreZc0 commented Oct 13, 2018

@Hoishin Should be fine now :)

@codecov
Copy link

codecov bot commented Oct 13, 2018

Codecov Report

Merging #63 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #63   +/-   ##
=======================================
  Coverage   82.26%   82.26%           
=======================================
  Files           4        4           
  Lines         141      141           
=======================================
  Hits          116      116           
  Misses         25       25
Impacted Files Coverage Δ
generators/panel/index.js 77.55% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79816d7...4c746ef. Read the comment docs.

@Hoishin
Copy link
Member

Hoishin commented Oct 13, 2018

Thank you!

@Hoishin Hoishin merged commit 56056f4 into nodecg:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants