Add deprecation warning #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RubenVerborgh
force-pushed
the
docs/deprecation
branch
from
ac939ed to
90fce1e
Compare
michielbdejong
approved these changes
Dec 8, 2020
| that allows your apps to log in and read/write data using | ||
| a [Node Solid Server](https://github.com/solid/node-solid-server/). | ||
|
|
||
| **⚠️ New projects should use [solid-client-authn](https://github.com/inrupt/solid-client-authn-js) instead, |
|
I think it would be very helpful to merge this. I just found PR by chance. I ended up in this repo multiple times while trying no navigate the ecosystem. For example https://github.com/solid/react-components still uses it. |
|
I will merge; @michielbdejong feel free to add your suggestion as well (I don’t know solid-auth-fetcher so my description wouldn’t be accurate). |
|
DPOP is also implemented in NSS and should be added to the solid server list in the warning |
|
Hopefully inrupt/solid-client-authn-js#423 and inrupt/solid-client-authn-js#538 will one day be resolved and we can merge solid-auth-fetcher and inrupt's version of it back together |
michielbdejong
added a commit
that referenced
this pull request
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that the authentication method used by this library is no longer the one recommended by the specification, I propose to add this warning to help developers find their way.