Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hasPaid(agent) function to ACL check #38

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Add hasPaid(agent) function to ACL check #38

wants to merge 5 commits into from

Conversation

michielbdejong
Copy link
Member

No description provided.

@michielbdejong michielbdejong marked this pull request as draft March 3, 2021 13:15
@michielbdejong michielbdejong changed the title Add hasPaid(agent) function to ACL check [WiP] Add hasPaid(agent) function to ACL check Mar 3, 2021
@michielbdejong
Copy link
Member Author

Linked to nodeSolidServer/node-solid-server#1577

@michielbdejong michielbdejong mentioned this pull request Mar 3, 2021
Open
@michielbdejong michielbdejong changed the title [WiP] Add hasPaid(agent) function to ACL check Add hasPaid(agent) function to ACL check Sep 2, 2021
@michielbdejong michielbdejong marked this pull request as ready for review September 2, 2021 11:42
@michielbdejong
Copy link
Member Author

michielbdejong commented Sep 2, 2021 •
edited
Loading

This PR goes together with nodeSolidServer/node-solid-server#1577 and https://github.com/solid/monetization-tests/blob/main/run-against-nss.sh

kjetilk
kjetilk reviewed Sep 2, 2021
View reviewed changes
Copy link
Member

@kjetilk kjetilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The design looks sane to me, but I would much prefer to see this go into WAC first.

@michielbdejong michielbdejong mentioned this pull request Sep 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjetilk kjetilk kjetilk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michielbdejong @kjetilk