Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow the auth context to be configured #67

Merged
merged 1 commit into from
Dec 18, 2014

Conversation

qraynaud
Copy link
Contributor

This is useful because ADFS does not recognize the default value in this plugin (urn:oasis:names:tc:SAML:2.0:ac:classes:PasswordProtectedTransport) and wants http://schemas.microsoft.com/ws/2008/06/identity/authenticationmethod/windows in there instead.

I believe you can also set disableRequestedAuthnContext to true to get this to work. Since this parameter was not documented I also added an entry for it.

@ploer
Copy link
Contributor

ploer commented Dec 13, 2014

Thanks for the PR, looks good!

Two requests:

  1. Let's call the option authnContext instead of authenticationMethod, since that's the underlying SAML name.

  2. Please add a mocha self-test for this behavior. (probably an additional entry in the 'captured SAML requests' group)

@qraynaud
Copy link
Contributor Author

Thanks for the quick review. I'll make the suggested modifications early next week.

@qraynaud
Copy link
Contributor Author

done, this should be better

@ploer
Copy link
Contributor

ploer commented Dec 18, 2014

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants