improve ADFS compatibility #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…wo levels down -- ADFS generates SAML that is signed three levels down
This was referenced Jan 17, 2019
vandernorth
pushed a commit
to vandernorth/passport-saml
that referenced
this pull request
Oct 29, 2020
…s. Tests: are line endings causing trouble? node-saml#2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using passport-saml with ADFS.
My ADFS produces SAML with enveloped signatures where the Signature node is three levels down, and the existing XPath in validateSignature is only looking for Signature nodes two levels down.
As far as I can tell from the SAML spec, the Signature node is allowed anywhere in the document. I validated both SAML from ADFS and feide.no against the XSD schemas provided alongside the SAML spec.