Working on Windows 7 #179
Open
Working on Windows 7 #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi there. Thanks for the contribution. I've added you as a collaborator on this project. Feel free to merge as you see fit. Getting proper Windows support would be great. |
|
@jimjibone can you resolve the conflict please? |
|
CAN WE PLEASE GET THIS FIXED?! |
|
@mranney can you add @mildsunrise as collaborator too? |
|
@bipolarmorgan ummm, there's not an easy fix To get this module working on Windows I'm afraid more work is needed, see #249 (comment) |
|
is this still not fixed? |
|
@PatrickSantoZZ it's not a fix. It's a new feature. We'd need to write an important amount of code to adapt to Windows. |
nice to know. thank you :3 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to binding.gyp to include the various files on Windows/Linux/etc and edited some C++ source to allow compilation on Windows.
Edited the README to cover a few build instructions for Windows.
Added a PCAP file reading example.