Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should ignore getaddrinfo ENOTFOUND error #22

Merged
merged 1 commit into from
May 24, 2017

Conversation

fengmk2
Copy link
Member

@fengmk2 fengmk2 commented May 24, 2017

closes #21

@mention-bot
Copy link

@fengmk2, thanks for your PR! By analyzing the history of the files in this pull request, we identified @xudafeng to be a potential reviewer.

@fengmk2 fengmk2 added the bug label May 24, 2017
@fengmk2 fengmk2 requested a review from dead-horse May 24, 2017 03:52
@codecov
Copy link

codecov bot commented May 24, 2017

Codecov Report

Merging #22 into master will increase coverage by 0.35%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
+ Coverage   93.87%   94.23%   +0.35%     
==========================================
  Files           2        2              
  Lines          49       52       +3     
==========================================
+ Hits           46       49       +3     
  Misses          3        3
Impacted Files Coverage Δ
lib/detect-port.js 94.11% <100%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e99c992...320048b. Read the comment docs.

@fengmk2 fengmk2 merged commit 792bccd into master May 24, 2017
@fengmk2 fengmk2 deleted the fix-localhost-not-binding branch May 24, 2017 04:01
@fengmk2
Copy link
Member Author

fengmk2 commented May 24, 2017

1.1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

detect error when localhost is not binding
2 participants