Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Freezes for a minute when OS X Firewall is enabled #3

Closed
gaearon opened this issue Aug 1, 2016 · 0 comments
Closed

Freezes for a minute when OS X Firewall is enabled #3

gaearon opened this issue Aug 1, 2016 · 0 comments

Comments

@gaearon
Copy link
Collaborator

gaearon commented Aug 1, 2016

detect() call takes up to a minute when the firewall is enabled.
This was originally reported in facebook/create-react-app#302 which uses this library.

Steps to reproduce:

1. Enable Firewall:

screen shot 2016-08-01 at 14 40 37

2. Block incoming connections:

screen shot 2016-08-01 at 14 40 40
gaearon added a commit to gaearon/detect-port that referenced this issue Aug 1, 2016
@gaearon
Fix freeze on OS X with Firewall enabled
33d00f2 
It appears that letting Node.js use localhost by default is much faster (a few seconds instead of a minute) than using external IP for determining whether the port is busy.
Fixes node-modules#3.
@gaearon gaearon mentioned this issue Aug 1, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gaearon