Fix break on undefined function + fix protocol debug log. #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 11, 2014 14:45
The commit 721404 modified internal debugger implementation to use Node's debugger `Protocol` to parse data sent by the V8 debugger. With that change in place, `msg.body` is no longer a string, but a (JSON) object instead. As a result, `event` and `response` entries printed `[object Object]` instead of the JSON payload. This commit fixes the problem by calling `JSON.stringify(msg.body)`.
Fix a bug where `TypeError: undefined is not a function` was ignored in "break on uncaught exceptions" mode. This exception is thrown by a V8 builtin function CALL_NON_FUNCTION defined in an internal script `v8/src/runtime.js`, which is not tracked by Node Inspector. Before this change, Node Inspector incorrectly assumed that the script is a code loaded via `eval`.
This was referenced Aug 11, 2014
|
I think - it's a good point, that we don't need to see LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeError: undefined is not a functionwas ignoredin "break on uncaught exceptions" mode.
Close #344.
@3y3 please review