fix: remove gently hijack and tests

[kedarv]

This pull request removes references to gently, and deletes some old tests that required gently. This should fix #337

[kedarv]

Hm..looks like a test is failing on travis with node13

Error [ERR_STREAM_DESTROYED]: Cannot call write after a stream was destroyed
      at WriteStream._write (internal/fs/streams.js:361:33)
      at WriteStream.<anonymous> (internal/fs/streams.js:357:12)
      at Object.onceWrapper (events.js:412:26)
      at WriteStream.emit (events.js:317:22)
      at internal/fs/streams.js:348:12
      at FSReqCallback.oncomplete (fs.js:153:23)
  Emitted 'error' event on WriteStream instance at:
      at errorOrDestroy (internal/streams/destroy.js:128:12)
      at onwriteError (_stream_writable.js:473:3)
      at onwrite (_stream_writable.js:494:7)
      at WriteStream._write (internal/fs/streams.js:361:30)
      at WriteStream.<anonymous> (internal/fs/streams.js:357:12)
      [... lines matching original stack trace ...]
      at FSReqCallback.oncomplete (fs.js:153:23) {
    code: 'ERR_STREAM_DESTROYED'
  }

[lgtm-com]

This pull request fixes 1 alert when merging ddb2577 into b04b5ac - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[tunnckoCore]

Great. Thanks for the PR!

I would rather somehow ignore the run of test/legacy tests or easiest way probably is to move to test-legacy in the root just in case for backup.

I'm still not sure what's test/legacy is for, but may have some interesting cases for future.

[tunnckoCore]

Hm..looks like a test is failing on travis with node13

@kedarv, known issue. You can remove it from Travis, otherwise I will anyway. ;D

[kedarv]

Cool, removed Node 13 from travis.yaml and moved the failing legacy tests to test-legacy/ with a readme for future reference.

[lgtm-com]

This pull request fixes 1 alert when merging ba791ef into b04b5ac - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[tunnckoCore]

Great! :) One more thing. Move test/legacy/common.js too.

[kedarv]

Great! :) One more thing. Move test/legacy/common.js too.

I ended up moving all of the legacy/simple tests up to the "dummy" directory. But, moving common.js up causes test/legacy/system/test-multi-video-upload.js and test/legacy/integration/test-multipart-parser.js to fail

[lgtm-com]

This pull request fixes 1 alert when merging 0137389 into b04b5ac - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[tunnckoCore]

That's why we just move the whole test/legacy/ to test-legacy/. Cuz they seems connected since they are in that legacy folder together.

The reason for move is to not run these tests at all.

[lgtm-com]

This pull request fixes 1 alert when merging 499eba7 into b04b5ac - view on LGTM.com

fixed alerts:

• 1 for Useless assignment to local variable

[tunnckoCore]

cool!

[tunnckoCore]

@all-contributors please add @kedarv for code and test

[allcontributors]

@tunnckoCore

I've put up a pull request to add @kedarv! 🎉

[tunnckoCore]

@all-contributors please add @kedarv for bug

[allcontributors]

@tunnckoCore

I've put up a pull request to add @kedarv! 🎉

[songkeys]

Could this pr also be merged into the 1.x branch?

[tunnckoCore]

@songkeys

I didn't want to touch v1 and that's why we published v1.2.2 with just a readme update.

Any reason to not use/try v2 canary? When v2 moves to latest it will be more or less the current codebase with not many changes, so feedback is welcome.

[songkeys]

@tunnckoCore

Yeah, I'm considering moving. But the issue #635 (comment) here makes me wonder if there will be a stable v2. Also not so sure about the breaking changes. The changelog currently is not clearly structured.

I guess I'll wait for a stable v2 then. Hope there is a roadmap and release plan about this repo.

[tunnckoCore]

@songkeys

The v2 basically is clearing the whole issue tracker, PRs and modernizing the codebase, without some huge breaking changes - it's major bump for safety. The only breaking I can think of is the exports, yet we still have the fallbacks in canary.

I'm gearing up for an active year and hope to release v3 too. Roadmap and predictable release plan is understandable though, and coming.