Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Function as target object allowed #3

Merged
merged 1 commit into from
Jan 2, 2018
Merged

Function as target object allowed #3

merged 1 commit into from
Jan 2, 2018

Conversation

piotrkobzda
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Jan 2, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 12eccd7 on piotrkobzda:master into 8a0984c on node-ffi-napi:master.

@addaleax addaleax mentioned this pull request Jan 2, 2018
Closed
addaleax
addaleax approved these changes Jan 2, 2018
View reviewed changes
Copy link
Contributor

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I’ve also opened an upstream issue @ nodejs/node-addon-api#207, I think it might make sense to change this in the node-addon-api wrapper as well

@addaleax addaleax merged commit c5450d7 into node-ffi-napi:master Jan 2, 2018
@addaleax
Copy link
Contributor

addaleax commented Jan 2, 2018

Published as [email protected] 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrkobzda @coveralls @addaleax