Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring #1817

Merged
merged 4 commits into from
Sep 11, 2023
Merged

Code refactoring #1817

merged 4 commits into from
Sep 11, 2023

Conversation

tosemml
Copy link
Contributor

@tosemml tosemml commented Sep 5, 2023

These slight code adjustments aim to enhance Pythonic quality by incorporating python str.join

Copy link
Collaborator

@monorimet monorimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we remove res = f"[{res[:-2]}]" and just use res = ", ".join(ext_list) ? seems like we add and remove a comma at the end which doesn't need to happen anymore.

@tosemml
Copy link
Contributor Author

tosemml commented Sep 7, 2023

Refactored

@dan-garvey
Copy link
Member

Looks good to me. Test failure seems unrelated

@dan-garvey dan-garvey enabled auto-merge (squash) September 11, 2023 16:28
Copy link
Collaborator

@monorimet monorimet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dan-garvey dan-garvey merged commit c61b6f8 into nod-ai:main Sep 11, 2023
2 of 6 checks passed
gpetters94 added a commit to gpetters-amd/SHARK that referenced this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants