Support for Hazelcast v3.9 #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Passing the ClientContext means it'll be a breaking change, isn't it? Yet ... another ... reflective ... factory ;) |
|
Btw thanks for looking into it already! :) Unfortunately I have some other stuff I work on right now but glad to see you're working on it! |
|
Well, it might be a breaking change for 3.7, but it works for 3.8 and 3.9 now. So I am not sure how to handle that and provide backward compatibility. |
|
Here it is, compatibility fixes for 3.8! |
|
I actually think to release V2 just now (with support for 3.7/3.8) and remove the old versions for V3 which would be 3.9+, what do you think? |
|
Yes, definitely. There are too many changes to maintain. |
|
is there any problem? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems sufficient to support 3.9-SNAPSHOT as-is now. Does not solve lots of
@Deprecatedstuff.