feat: PC-14959 Extend kind SLO with QueryValidationStatus #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukasz-dobek
force-pushed
the
PC-14959-add-query-checker-status
branch
from
874b3b4 to
1a19b74
Compare
lukasz-dobek
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
lukasz-dobek
force-pushed
the
PC-14959-add-query-checker-status
branch
from
c0c0467 to
9c49b58
Compare
natalialanga
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In certain cases we want to include query validation status per objective in SLO status itself.
Summary
This PR adds
QueryValidationStatusdefinition to kind SLOstatusfield. For now, it's availability will be limited in the API.Release Notes
Add
QueryValidationStatusdefinition to kind SLOstatusfield.