Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support Website metrics in LogicMonitor [PC-14860] #593

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

feat: Support Website metrics in LogicMonitor [PC-14860] #593

wants to merge 25 commits into from

Conversation

dawidwisn
Copy link
Contributor

@dawidwisn dawidwisn commented Nov 20, 2024 •
edited
Loading

Motivation

Support Website metrics in LogicMonitor

Summary

This PR extends LogicMonitor metric spec with new fields and a new value for queryType = website_metrics.
Depending on queryType, different fields are required. For queryType:

  • device_metrics - required fields: deviceDataSourceInstanceId, graphId and line
  • website_metrics - required fields: websiteId, checkpointId, graphName and line
    Changes are backward compatible.

Example:

logicMonitor:
    queryType: website_metrics
    line: MIN RTT
    websiteId: "1"
    checkpointId: "1044712023"
    graphName: "responseTime"

Release Notes

  • Support Website metrics in LogicMonitor

@n9-machine-user n9-machine-user added enhancement New feature or request go minor labels Nov 20, 2024
@dawidwisn dawidwisn marked this pull request as ready for review November 28, 2024 14:54
bdw-nobl9
bdw-nobl9 approved these changes Dec 1, 2024
View reviewed changes
manifest/v1alpha/slo/metrics_logic_monitor.go Outdated Show resolved Hide resolved
manifest/v1alpha/slo/metrics_logic_monitor_test.go Outdated Show resolved Hide resolved
manifest/v1alpha/slo/metrics_logic_monitor_test.go Outdated Show resolved Hide resolved
dawidwisn and others added 13 commits December 2, 2024 09:43
@dawidwisn @bdw-nobl9
Update manifest/v1alpha/slo/metrics_logic_monitor.go
2e7d82f 
Co-authored-by: bdw-nobl9 <[email protected]>
@dawidwisn @bdw-nobl9
Update manifest/v1alpha/slo/metrics_logic_monitor_test.go
377da3f 
Co-authored-by: bdw-nobl9 <[email protected]>
@dawidwisn @bdw-nobl9
Update manifest/v1alpha/slo/metrics_logic_monitor_test.go
68542d5 
Co-authored-by: bdw-nobl9 <[email protected]>
@dawidwisn
Merge branch 'main' into PC-14860-Support-Website-metrics-in-LogicMon…
a6f4508 
…itor
@dawidwisn
Merge branch 'main' into PC-14860-Support-Website-metrics-in-LogicMon…
94e30a4 
…itor
@dawidwisn
PC-14860 lint
614cb1a
@dawidwisn
PC-14860 add QueryType validation in Count Metrics
3d780af
@dawidwisn
Merge branch 'main' into PC-14860-Support-Website-metrics-in-LogicMon…
0fdd8de 
…itor
@dawidwisn
Merge branch 'main' into PC-14860-Support-Website-metrics-in-LogicMon…
efa0f10 
…itor
@dawidwisn
Merge branch 'main' into PC-14860-Support-Website-metrics-in-LogicMon…
d87de67 
…itor
@dawidwisn
PC-14860 revert changes for backward compatibility
11824bc
@dawidwisn
PC-14860 format
af114f8
@dawidwisn
PC-14860 generate
ec9b686
@dawidwisn dawidwisn mentioned this pull request Dec 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdw-nobl9 bdw-nobl9 bdw-nobl9 approved these changes

@nieomylnieja nieomylnieja Awaiting requested review from nieomylnieja nieomylnieja is a code owner

@skrolikiewicz skrolikiewicz Awaiting requested review from skrolikiewicz skrolikiewicz is a code owner

@daniel-zelazny daniel-zelazny Awaiting requested review from daniel-zelazny daniel-zelazny is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request go minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dawidwisn @bdw-nobl9 @n9-machine-user