feat: Update Honeycomb config to support only single query good over total [PC-14879] #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…comb-config-to-support-only-single-query-goodtotal
nieomylnieja
requested review from
skrolikiewicz and
daniel-zelazny
as code owners
n9-machine-user
added
breaking-change
…only-single-query-goodtotal
nikodemrafalski
approved these changes
Nov 21, 2024
nieomylnieja
force-pushed
the
PC-14879-update-honeycomb-config-to-support-only-single-query-goodtotal
branch
from
08293d7 to
6e4462a
Compare
nikodemrafalski
approved these changes
Nov 26, 2024
…only-single-query-goodtotal
|
/build |
…-query-goodtotal' of github.com:nobl9/nobl9-go into PC-14879-update-honeycomb-config-to-support-only-single-query-goodtotal
|
/build |
nikodemrafalski
deleted the
PC-14879-update-honeycomb-config-to-support-only-single-query-goodtotal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Improved handling of some validation flows and corrected
whenCountMetricIs(it was not handling single query).Added tests which ensure that generated examples contain all the supported variants of a given SLO.
Added examples of single query to Splunk.
Release Notes
Added
spec.objectives[*].goodTotal.honeycombsingle query count metrics support for Honeycomb SLOs.This configuration only supports
attributeproperty and does not supportcalculationproperty.