feat: Add e2e tests for Reports, extend reports validation #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natalialanga
requested review from
nieomylnieja,
skrolikiewicz and
daniel-zelazny
as code owners
lukasz-dobek
approved these changes
Sep 12, 2024
renovate bot
referenced
this pull request
in nobl9/sloctl
Sep 14, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/nobl9/nobl9-go](https://redirect.github.com/nobl9/nobl9-go) | `v0.84.1-rc4` -> `v0.84.1-rc6` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>nobl9/nobl9-go (github.com/nobl9/nobl9-go)</summary> ### [`v0.84.1-rc6`](https://redirect.github.com/nobl9/nobl9-go/releases/tag/v0.84.1-rc6) [Compare Source](https://redirect.github.com/nobl9/nobl9-go/compare/v0.84.1-rc5...v0.84.1-rc6) #### What's Changed - feat: Add e2e tests for Reports, extend reports validation by [@​natalialanga](https://redirect.github.com/natalialanga) in [https://github.com/nobl9/nobl9-go/pull/541](https://redirect.github.com/nobl9/nobl9-go/pull/541) **Full Changelog**: nobl9/nobl9-go@v0.84.1-rc5...v0.84.1-rc6 ### [`v0.84.1-rc5`](https://redirect.github.com/nobl9/nobl9-go/releases/tag/v0.84.1-rc5) [Compare Source](https://redirect.github.com/nobl9/nobl9-go/compare/v0.84.1-rc4...v0.84.1-rc5) ### What's Changed #### 🚀 Features - feat: PC-13758 Add limits for recurring events ([#​533](https://redirect.github.com/nobl9/nobl9-go/issues/533)) [@​kubaceg](https://redirect.github.com/kubaceg) > Added frequency validation in `BudgetAdjustments` rrule field. - feat: PC-13724 Add custom thresholds for SHR ([#​530](https://redirect.github.com/nobl9/nobl9-go/issues/530)) [@​lukasz-dobek](https://redirect.github.com/lukasz-dobek) > `Thresholds` object with three fields (`GreenGreaterThan`, > `RedLessThanOrEqualTo` and `ShowNoData`) was added to > `SystemHealthReviewConfig`. It allows users to define custom values for > `Healthy` (`Green`), `AtRisk` (`Yellow`) and `Exhausted` (`Red`) > thresholds and to decide whether to display or hide `NoData` SLOs on > System Health Review report. It will be available once Nobl9 platform > version 1.97.2 is released. - feat: Switch to govy for validation ([#​527](https://redirect.github.com/nobl9/nobl9-go/issues/527)) [@​nieomylnieja](https://redirect.github.com/nieomylnieja) > `nobl9-go` is switching to a brand new validation library, > [govy](https://redirect.github.com/nobl9/govy). > The library was previously part of nobl9-go, but is now being open > sourced! Go check it out ;) #### 🧰 Maintenance <details> <summary>6 changes</summary> - chore: Add explicit generic arguments as workaround for GoLand IDE bug ([#​539](https://redirect.github.com/nobl9/nobl9-go/issues/539)) [@​ditrytus](https://redirect.github.com/ditrytus) - chore: export metric spec validation rules ([#​536](https://redirect.github.com/nobl9/nobl9-go/issues/536)) [@​kuklyy](https://redirect.github.com/kuklyy) - chore: Update module golang.org/x/tools/cmd/goimports to v0.25.0 ([#​540](https://redirect.github.com/nobl9/nobl9-go/issues/540)) [@​renovate](https://redirect.github.com/renovate) - chore: Update module golang.org/x/text to v0.18.0 ([#​535](https://redirect.github.com/nobl9/nobl9-go/issues/535)) [@​renovate](https://redirect.github.com/renovate) - chore: Update dependency yaml to v2.5.1 ([#​532](https://redirect.github.com/nobl9/nobl9-go/issues/532)) [@​renovate](https://redirect.github.com/renovate) - chore: Update minor and patch Golang dependencies ([#​491](https://redirect.github.com/nobl9/nobl9-go/issues/491)) [@​renovate](https://redirect.github.com/renovate) </details> </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,before 5am every weekday,every weekend" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/nobl9/sloctl). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC43NC4xIiwidXBkYXRlZEluVmVyIjoiMzguNzQuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwiZ29sYW5nIiwicmVub3ZhdGUiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary