Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: PC-11843 budget adjustment kind #262

Merged
merged 26 commits into from
Feb 16, 2024
Merged

Conversation

kubaceg
Copy link
Contributor

@kubaceg kubaceg commented Feb 6, 2024

Summary

Added new kind BudgetAdjustment for handling budget adjustment events.

Release Notes

New BudgetAdjustment kind which allows customers to schedule recurring future events that should be excluded from the Error Budget calculations in their SLOs

@kubaceg kubaceg changed the title PC-11843 budget adjustment kind feat: PC-11843 budget adjustment kind Feb 6, 2024
@n9-machine-user n9-machine-user added enhancement New feature or request minor labels Feb 6, 2024
@kubaceg
Copy link
Contributor Author

kubaceg commented Feb 6, 2024

/build

@kubaceg
Copy link
Contributor Author

kubaceg commented Feb 7, 2024

/build

@kubaceg
Copy link
Contributor Author

kubaceg commented Feb 7, 2024

/build

@kubaceg
Copy link
Contributor Author

kubaceg commented Feb 7, 2024

/build

@kubaceg
Copy link
Contributor Author

kubaceg commented Feb 7, 2024

/build

@kubaceg
Copy link
Contributor Author

kubaceg commented Feb 7, 2024

/build

@nieomylnieja nieomylnieja removed breaking-change We're breaking the API release-notes labels Feb 7, 2024
@nieomylnieja
Copy link
Collaborator

Please add Release Notes section with a short description of this new object we're adding and what it does :)

manifest/v1alpha/budgetadjustment/validation.go Outdated Show resolved Hide resolved
manifest/v1alpha/budgetadjustment/validation.go Outdated Show resolved Hide resolved
manifest/v1alpha/budgetadjustment/validation.go Outdated Show resolved Hide resolved
manifest/v1alpha/budgetadjustment/validation.go Outdated Show resolved Hide resolved
manifest/v1alpha/budgetadjustment/budget_adjustment.go Outdated Show resolved Hide resolved
manifest/v1alpha/budgetadjustment/budget_adjustment.go Outdated Show resolved Hide resolved
@kubaceg
Copy link
Contributor Author

kubaceg commented Feb 8, 2024

/build

Copy link
Contributor

@jakubpieta jakubpieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Collaborator

@nieomylnieja nieomylnieja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

manifest/v1alpha/budgetadjustment/budget_adjustment.go Outdated Show resolved Hide resolved
@kubaceg
Copy link
Contributor Author

kubaceg commented Feb 8, 2024

/build

@kubaceg
Copy link
Contributor Author

kubaceg commented Feb 14, 2024

/build

@kubaceg kubaceg requested a review from nieomylnieja February 14, 2024 10:05
@kubaceg
Copy link
Contributor Author

kubaceg commented Feb 14, 2024

/build

@kubaceg kubaceg marked this pull request as ready for review February 14, 2024 12:30
@kubaceg kubaceg force-pushed the PC-11843-extend-n-9-sdk-go branch from 83f8076 to 5b06cad Compare February 15, 2024 12:03
@kubaceg kubaceg merged commit 3356358 into main Feb 16, 2024
5 checks passed
@kubaceg kubaceg deleted the PC-11843-extend-n-9-sdk-go branch February 16, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants