-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sumologic timeslice validation [PC-7427] #238
feat: sumologic timeslice validation [PC-7427] #238
Conversation
ce5f558
to
b41d4de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leaving loose ideas and nitpicks, but approved! 🦭
I'm not a fan of adding a const just because a particular string is used in code and in tests. I would do it if the value were used twice in the actual system under test, but it's used once in this case. |
Fine for me (-: especially it would have only a single real usage |
You mentioned some other Bartek (-; |
…d-in-sumo-logic-logs-based-queries
…d-in-sumo-logic-logs-based-queries
…d-in-sumo-logic-logs-based-queries
Tightens sumo logic log query validation to allow timeslice operator to be used with 15,30 and 60 sec as an argument