[REVERTED] feat: PC-13893 Deprecate usage of objective's value field for Composite SLOs #1140
ditrytusrelease-drafter.yml
on: pull_request
update_release_draft
8s
Annotations
2 errors
|
update_release_draft
Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
{
name: 'HttpError',
id: '10526318182',
status: 422,
response: {
url: 'https://api.github.com/repos/nobl9/nobl9-go/releases',
status: 422,
headers: {
'access-control-allow-origin': '*',
'access-control-expose-headers': 'ETag, Link, Location, Retry-After, X-GitHub-OTP, X-RateLimit-Limit, X-RateLimit-Remaining, X-RateLimit-Used, X-RateLimit-Resource, X-RateLimit-Reset, X-OAuth-Scopes, X-Accepted-OAuth-Scopes, X-Poll-Interval, X-GitHub-Media-Type, X-GitHub-SSO, X-GitHub-Request-Id, Deprecation, Sunset',
connection: 'close',
'content-length': '210',
'content-security-policy': "default-src 'none'",
'content-type': 'application/json; charset=utf-8',
date: 'Fri, 23 Aug 2024 13:09:48 GMT',
'github-authentication-token-expiration': '2025-01-16 00:00:00 +0100',
'referrer-policy': 'origin-when-cross-origin, strict-origin-when-cross-origin',
server: 'github.com',
'strict-transport-security': 'max-age=31536000; includeSubdomains; preload',
vary: 'Accept-Encoding, Accept, X-Requested-With',
'x-accepted-github-permissions': 'contents=write; contents=write,workflows=write',
'x-content-type-options': 'nosniff',
'x-frame-options': 'deny',
'x-github-api-version-selected': '2022-11-28',
'x-github-media-type': 'github.v3; format=json',
'x-github-request-id': 'F048:B931F:410A3FB:4190B00:66C88A1C',
'x-ratelimit-limit': '5000',
'x-ratelimit-remaining': '4970',
'x-ratelimit-reset': '1724420790',
'x-ratelimit-resource': 'core',
'x-ratelimit-used': '30',
'x-xss-protection': '0'
},
data: {
message: 'Validation Failed',
errors: [
{
resource: 'Release',
code: 'invalid',
field: 'target_commitish'
}
],
documentation_url: 'https://docs.github.com/rest/releases/releases#create-a-release',
status: '422'
}
},
request: {
method: 'POST',
url: 'https://api.github.com/repos/nobl9/nobl9-go/releases',
headers: {
accept: 'application/vnd.github.v3+json',
'user-agent': 'probot/12.2.5 octokit-core.js/3.5.1 Node.js/20.13.1 (linux; x64)',
authorization: 'token [REDACTED]',
'content-type': 'application/json; charset=utf-8'
},
body: `{"target_commitish":"refs/pull/529/merge","name":"v0.84.1","tag_name":"v0.84.1","body":"# What's Changed\\n\\n* No changes\\n","draft":true,"prerelease":false,"make_latest":"true"}`,
request: {}
},
event: {
id: '10526318182',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '## Motivation\r\n' +
'\r\n' +
'Currently, we have `value` field required for all objectives in an SLO. We currently allow to not pass that field in YAML at all but it causes it to default to 0 anyway and is returned `value: 0`. This is inconsistent because GET yaml is different than APPLY YAML in such case.\r\n' +
'\r\n' +
"Composite SLOs always have exactly one objective, so as such `value` doesn’t matter for them at all as long as it doesn't change.\r\n" +
'\r\n' +
'Moreover, the existence of value is documented and used in examples which is confusing to new adopters of Composite SLOs because it is required, changing it will restart budget, but it doesn’t do anything.\r\n' +
'\r\n' +
'We want to encourage and allow not setting `value` field for Composite SLOs while maintaining backward compatibility with users who perhaps already explicitly set it.\r\n' +
'\r\n' +
'## Summary\r\n' +
'\r\n' +
'Changes:\r\n' +
'* `value` will be omitted if it is `null` in API.\r\n' +
'* `value` field is omitted in all Composite SLO examples and E2E tests.\r\n' +
'\r\n' +
'Cleanup:\r\n' +
'* SLO validation now explicitly passes gene
|
|
update_release_draft
HttpError: Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
at /home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:8462:21
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
at async Job.doExecute (/home/runner/work/_actions/release-drafter/release-drafter/v6/dist/index.js:30793:18)
{
name: 'AggregateError',
event: {
id: '10526318182',
name: 'pull_request',
payload: {
action: 'edited',
changes: {
body: {
from: '## Motivation\r\n' +
'\r\n' +
'Currently, we have `value` field required for all objectives in an SLO. We currently allow to not pass that field in YAML at all but it causes it to default to 0 anyway and is returned `value: 0`. This is inconsistent because GET yaml is different than APPLY YAML in such case.\r\n' +
'\r\n' +
"Composite SLOs always have exactly one objective, so as such `value` doesn’t matter for them at all as long as it doesn't change.\r\n" +
'\r\n' +
'Moreover, the existence of value is documented and used in examples which is confusing to new adopters of Composite SLOs because it is required, changing it will restart budget, but it doesn’t do anything.\r\n' +
'\r\n' +
'We want to encourage and allow not setting `value` field for Composite SLOs while maintaining backward compatibility with users who perhaps already explicitly set it.\r\n' +
'\r\n' +
'## Summary\r\n' +
'\r\n' +
'Changes:\r\n' +
'* `value` will be omitted if it is `null` in API.\r\n' +
'* `value` field is omitted in all Composite SLO examples and E2E tests.\r\n' +
'\r\n' +
'Cleanup:\r\n' +
'* SLO validation now explicitly passes generic parameters to avoid issue where GoLand IDE can not infer them.\r\n' +
'\r\n' +
'## Related changes\r\n' +
'\r\n' +
'This change requires updates in the platform code which are in this PR:\r\n' +
'\r\n' +
'Changes in `terraform-provider-nobl9` depend on this change in SDK:\r\n' +
' \r\n' +
'\r\n' +
'## Testing\r\n' +
'\r\n' +
'```go\r\n' +
'```\r\n' +
'\r\n' +
'## Release Notes\r\n' +
'\r\n' +
'`spec.objective[0].value` field can be safely omitted for Composite SLOs.'
}
},
number: 529,
organization: {
avatar_url: 'https://avatars.githubusercontent.com/u/58781264?v=4',
description: '',
events_url: 'https://api.github.com/orgs/nobl9/events',
hooks_url: 'https://api.github.com/orgs/nobl9/hooks',
id: 58781264,
issues_url: 'https://api.github.com/orgs/nobl9/issues',
login: 'nobl9',
members_url: 'https://api.github.com/orgs/nobl9/members{/member}',
node_id: 'MDEyOk9yZ2FuaXphdGlvbjU4NzgxMjY0',
public_members_url: 'https://api.github.com/orgs/nobl9/public_members{/member}',
repos_url: 'https://api.github.com/orgs/nobl9/repos',
url: 'https://api.github.com/orgs/nobl9'
},
pull_request: {
_links: {
comments: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/issues/529/comments'
},
commits: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/pulls/529/commits'
},
html: { href: 'https://github.com/nobl9/nobl9-go/pull/529' },
issue: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/issues/529'
},
review_comment: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/pulls/comments{/number}'
},
review_comments: {
href: 'https://api.github.com/repos/nobl9/nobl9-go/pulls/529/comments'
},
self: {
href: 'https://api.github.com/repos/nobl9/nobl9
|