Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for favorites #37
base: master
Are you sure you want to change the base?
Add support for favorites #37
Changes from 5 commits
de3404d
2ffa647
470f9af
7bc7672
a0e75a3
b894ed2
d39612b
d3b95d6
b980176
1b6e3af
eb6bfef
a20294d
7460c20
fd6270b
10ac12d
d58cfd6
2d53545
f68a588
50b6a80
847d6ce
71f444d
49862ba
2aa49d1
4490bdb
070a719
a47c144
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we loading these values into the cache on connection? The enumerate command will typically fetch these values directly instead of grabbing them from the cache.
How we handle this is completely up for debate, just trying to understand it better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No compelling reason other than it would happen during startup regardless. Since this is dependent on controller type, it doesn't make sense to pre-fetch these.