Add explicit sub-canopy 3-layers effect in photolysis and gas-phase (…

[iri01]

…cb6r3_ae6_aq mechanism)

activated with CANOPY_SHADE namelist parameter.

PR Checklist

• This PR has been tested on an RDHPCS machine and/or WCOSS2. Please select below:

  • RDHPCS.
  • WCOSS2.

• This PR has been tested with the ufs-srweather-app workflow online-cmaq branch.

• New or updated input data is required by this PR.

• Baselines are expected to change.

Description

Issue(s) addressed

Dependencies

[drnimbusrain]

@iri01

Looks OK as I go through it this morning. I think after retroactively, at our next meeting we go through these changes. I only have a small comment on the canopy mask and FCH threshold here compared to the recent results you have shown.

I do have one major question here. Are we missing your hrdriver.F changes here where the gas phase solver is applied on canopy levels? If so please add the required changes (in make files, src/model/src/hrdriver.F files, etc.) here.

Also, thinking ahead, we have moved to using the Rosenbrock (RB) solver instead of EBI in future AQMv8. Therefore, I think if possible you should add the corresponding gas phase solver/driver changes for RB to this PR (e.g., https://github.com/USEPA/CMAQ/blob/5.2.1/CCTM/src/gas/ros3/rbdriver.F#L638), so that when we merge in CMAQ54 updates we get the canopy changes for AQMv8 RB solver option.

Thank you!

[drnimbusrain]

@iri01 Thanks looks good from my perspective here. Just need a short test of this package (i.e., feature/aqm_canopy_phot3lev) with CMAQ521 still using both the HR (EBI) and RB solvers with canopy on - off. Then we can merge! Can you test this package with both solvers to make sure they work and get results as expected?
You have already updated and added local versions of both HR and RB here and to the cmake (for canopy), and just need to make one small change to your cmake path locally to test the RB solver, as Wei has done here: b33ded4#diff-b370bb911efd47962ec736d4070a44da7a643b21dca9e4a90ea087b1910eb4c6R79