Skip to content

Commit

Permalink
[BGP]Increasing maximum-paths to 514 (sonic-net#20745)
Browse files Browse the repository at this point in the history
- Why I did it
This PR follows sonic-net#20744
Increasing the maximum-paths to 514. Currently value of 64 restricts the maximum paths that can created by BGP.

- How I did it
Updated constants file.

- How to verify it
Modified UT to verify.
  • Loading branch information
dgsudharsan authored Dec 5, 2024
1 parent f43d350 commit b25a06f
Show file tree
Hide file tree
Showing 21 changed files with 57 additions and 57 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ router bgp {{ DEVICE_METADATA['localhost']['bgp_asn'] }} vrf {{ vnet_name }}
address-family ipv4 unicast
neighbor {{ neighbor_addr }} activate
neighbor {{ neighbor_addr }} soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
{% endif %}
address-family l2vpn evpn
Expand Down
4 changes: 2 additions & 2 deletions files/image_config/constants/constants.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ constants:
enabled: true
maximum_paths:
enabled: true
ipv4: 64
ipv6: 64
ipv4: 514
ipv6: 514
allow_list:
enabled: true
default_action: "permit" # or "deny"
Expand Down
4 changes: 2 additions & 2 deletions platform/vs/tests/bgp/files/gr_livelock/bgpd.conf
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@ router bgp 65501
neighbor 10.0.0.1 remote-as 65502
address-family ipv4
neighbor 10.0.0.1 activate
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor 10.0.0.3 remote-as 65503
address-family ipv4
neighbor 10.0.0.3 activate
maximum-paths 64
maximum-paths 514
exit-address-family
4 changes: 2 additions & 2 deletions platform/vs/tests/bgp/files/no_export/bgpd.conf
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@ router bgp 65501
neighbor 10.0.0.1 remote-as 65502
address-family ipv4
neighbor 10.0.0.1 activate
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor 10.0.0.3 remote-as 65503
address-family ipv4
neighbor 10.0.0.3 activate
maximum-paths 64
maximum-paths 514
exit-address-family
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ router bgp 555 vrf First
address-family ipv4 unicast
neighbor 10.10.10.1 activate
neighbor 10.10.10.1 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
address-family l2vpn evpn
advertise ipv4 unicast
Expand All @@ -31,7 +31,7 @@ router bgp 555 vrf Second
address-family ipv4 unicast
neighbor 20.20.20.1 activate
neighbor 20.20.20.1 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
address-family l2vpn evpn
advertise ipv4 unicast
Expand Down
4 changes: 2 additions & 2 deletions src/sonic-config-engine/tests/sample_output/py2/bgpd_frr.conf
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ router bgp 65100
!
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@ router bgp 65100
!
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ router bgp 65100
!
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ router bgp 65100
!
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ router bgp 65100
exit-address-family
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
18 changes: 9 additions & 9 deletions src/sonic-config-engine/tests/sample_output/py2/bgpd_quagga.conf
Original file line number Diff line number Diff line change
Expand Up @@ -35,66 +35,66 @@ router bgp 65100
neighbor 10.0.0.59 allowas-in 1
neighbor 10.0.0.59 activate
neighbor 10.0.0.59 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor 10.0.0.61 remote-as 64600
neighbor 10.0.0.61 description ARISTA03T1
address-family ipv4
neighbor 10.0.0.61 allowas-in 1
neighbor 10.0.0.61 activate
neighbor 10.0.0.61 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor 10.0.0.63 remote-as 64600
neighbor 10.0.0.63 description ARISTA04T1
address-family ipv4
neighbor 10.0.0.63 allowas-in 1
neighbor 10.0.0.63 activate
neighbor 10.0.0.63 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor fc00::7e remote-as 64600
neighbor fc00::7e description ARISTA04T1
address-family ipv6
neighbor fc00::7e allowas-in 1
neighbor fc00::7e activate
neighbor fc00::7e soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor fc00::7a remote-as 64600
neighbor fc00::7a description ARISTA03T1
address-family ipv6
neighbor fc00::7a allowas-in 1
neighbor fc00::7a activate
neighbor fc00::7a soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor 10.0.0.57 remote-as 64600
neighbor 10.0.0.57 description ARISTA01T1
address-family ipv4
neighbor 10.0.0.57 allowas-in 1
neighbor 10.0.0.57 activate
neighbor 10.0.0.57 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor fc00::76 remote-as 64600
neighbor fc00::76 description ARISTA02T1
address-family ipv6
neighbor fc00::76 allowas-in 1
neighbor fc00::76 activate
neighbor fc00::76 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor fc00::72 remote-as 64600
neighbor fc00::72 description ARISTA01T1
address-family ipv6
neighbor fc00::72 allowas-in 1
neighbor fc00::72 activate
neighbor fc00::72 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
!
maximum-paths 64
maximum-paths 514
!
route-map ISOLATE permit 10
set as-path prepend 65100
Expand Down
4 changes: 2 additions & 2 deletions src/sonic-config-engine/tests/sample_output/py2/frr.conf
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ router bgp 65100
!
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ router bgp 4000 vrf VnetFE
address-family ipv4 unicast
neighbor 192.168.0.1 activate
neighbor 192.168.0.1 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
address-family l2vpn evpn
advertise ipv4 unicast
Expand Down Expand Up @@ -74,10 +74,10 @@ router bgp 4000
!
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
4 changes: 2 additions & 2 deletions src/sonic-config-engine/tests/sample_output/py3/bgpd_frr.conf
Original file line number Diff line number Diff line change
Expand Up @@ -67,10 +67,10 @@ router bgp 65100
!
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,10 @@ router bgp 65100
!
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,10 +77,10 @@ router bgp 65100
!
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,10 @@ router bgp 65100
!
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -82,10 +82,10 @@ router bgp 65100
exit-address-family
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
18 changes: 9 additions & 9 deletions src/sonic-config-engine/tests/sample_output/py3/bgpd_quagga.conf
Original file line number Diff line number Diff line change
Expand Up @@ -35,66 +35,66 @@ router bgp 65100
neighbor 10.0.0.57 allowas-in 1
neighbor 10.0.0.57 activate
neighbor 10.0.0.57 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor fc00::72 remote-as 64600
neighbor fc00::72 description ARISTA01T1
address-family ipv6
neighbor fc00::72 allowas-in 1
neighbor fc00::72 activate
neighbor fc00::72 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor 10.0.0.59 remote-as 64600
neighbor 10.0.0.59 description ARISTA02T1
address-family ipv4
neighbor 10.0.0.59 allowas-in 1
neighbor 10.0.0.59 activate
neighbor 10.0.0.59 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor fc00::76 remote-as 64600
neighbor fc00::76 description ARISTA02T1
address-family ipv6
neighbor fc00::76 allowas-in 1
neighbor fc00::76 activate
neighbor fc00::76 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor 10.0.0.61 remote-as 64600
neighbor 10.0.0.61 description ARISTA03T1
address-family ipv4
neighbor 10.0.0.61 allowas-in 1
neighbor 10.0.0.61 activate
neighbor 10.0.0.61 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor fc00::7a remote-as 64600
neighbor fc00::7a description ARISTA03T1
address-family ipv6
neighbor fc00::7a allowas-in 1
neighbor fc00::7a activate
neighbor fc00::7a soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor 10.0.0.63 remote-as 64600
neighbor 10.0.0.63 description ARISTA04T1
address-family ipv4
neighbor 10.0.0.63 allowas-in 1
neighbor 10.0.0.63 activate
neighbor 10.0.0.63 soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
neighbor fc00::7e remote-as 64600
neighbor fc00::7e description ARISTA04T1
address-family ipv6
neighbor fc00::7e allowas-in 1
neighbor fc00::7e activate
neighbor fc00::7e soft-reconfiguration inbound
maximum-paths 64
maximum-paths 514
exit-address-family
!
maximum-paths 64
maximum-paths 514
!
route-map ISOLATE permit 10
set as-path prepend 65100
Expand Down
4 changes: 2 additions & 2 deletions src/sonic-config-engine/tests/sample_output/py3/frr.conf
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ router bgp 65100
!
!
address-family ipv4
maximum-paths 64
maximum-paths 514
exit-address-family
address-family ipv6
maximum-paths 64
maximum-paths 514
exit-address-family
!
! end of template: bgpd/bgpd.main.conf.j2
Expand Down
Loading

0 comments on commit b25a06f

Please sign in to comment.