[lts/2.0.y][Hotfix] Fix mqtt related test failure on lts/2.0.y branch #3578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anyj0527
requested review from
again4you,
dongju-chae,
gichan-jang,
helloahn,
jaeyun-jung,
jijoongmoon,
kimjh12,
kparichay,
leemgs,
lhs8928,
myungjoo,
wooksong,
zhoonit and
a team
as code owners
|
📝 TAOS-CI Version: 1.5.20200925. Thank you for submitting PR #3578. Please a submit 1commit/1PR (one commit per one PR) policy to get comments quickly from reviewers. Your PR must pass all verificiation processes of cibot before starting a review process from reviewers. If you are new member to join this project, please read manuals in documentation folder and wiki page. In order to monitor a progress status of your PR in more detail, visit http://nnstreamer.mooo.com/. |
This patch adds the implementation of the basic utility functions to get timestamps from the given or public NTP servers. Signed-off-by: Wook Song <[email protected]>
This patch introduces the self-synchronization mechanism of the Unix epoch timestamps. Note that if the 'ntp-sync' property is set to true (which means that if this feature is enabled), the pipeline would be stuck after a while. This is because most of the public NTP servers restrict clients not to poll too frequently. To fix it, polling intervals and caching mechanisms should be applied to the NPT utility functions. Signed-off-by: Wook Song <[email protected]>
- Remove a testcase which assumes no broker. - When a broker running in the test env, it fails. Signed-off-by: Yongjoo Ahn <[email protected]>
- Test invalid properties of mqttsink with `gst_harness_new_parse` instead of `g_object_set`. Signed-off-by: Yongjoo Ahn <[email protected]>
Change to wait until connection is successfully established within timeout limit. This patch fix the error: ERROR: MQTTSrc: cb_mqtt_on_connect_failure: failed to connect to the broker: TCP/TLS connect failure. Test pipeline: Publisher ```bash $ gst-launch-1.0 videotestsrc is-live=true ! video/x-raw,format=RGB,width=640,height=480,framerate=5/1 ! mqttsink pub-topic=test/videotestsrc ``` Subscriber ```bash $ gst-launch-1.0 mqttsrc sub-topic=test/videotestsrc ! video/x-raw,format=RGB,width=640,height=480,framerate=5/1 ! videoconvert ! ximagesink ``` Signed-off-by: gichan <[email protected]> Signed-off-by: Gichan Jang <[email protected]>
If the broker is not available, the mqtt element cannot be changed to the playing state. However, harnesses are used in the mqtt test, and errors occur if harnesses cannot be changed to the playing state. So, if there's no broker on the test environment, the test fails. For example, the build on the lunch pad failed. https://launchpadlibrarian.net/566158157/buildlog_ubuntu-bionic-amd64.nnstreamer_2.1.0.0-0~202110290743~ubuntu18.04.1_BUILDING.txt.gz Signed-off-by: Gichan Jang <[email protected]> Signed-off-by: gichan <[email protected]>
anyj0527
force-pushed
the
lts/2.0.y-fix-mqtt
branch
from
a75c533 to
c8fb495
Compare
jaeyun-jung
approved these changes
Nov 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick 6 commits from main branch to fix CI's mqtt test failure on lts/2.0,y branch
Self evaluation: