Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin.xml for 2017.1 compatibility #93

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

achinault
Copy link

@achinault achinault commented Apr 4, 2017

Make the plugin compatible with 2017.1 by recompiling with a incremented version number, would probably also require updating associated documentation.

Make it be compatible to 2017.1
@kshchepanovskyi
Copy link

You just incremented version, did it help?

As far as I understand this plugin uses some deprecated APIs, that were removed in release 2017.1.

I am just curious how JetBrains marks old plugins as "incompatible" with new IDE releases, because plugin.xml for this plugin does not have upper bound in idea-version section:

<idea-version since-build="133"/>

@achinault
Copy link
Author

achinault commented Apr 4, 2017

Yep, it got it running on at least my machine(I compiled with the changes and manually installed). I did notice some deprecated warnings but it is out of my scope at the moment for me to try to tackle those. AFAIK It has more to do with recompiling with 2017.1 than anything else, and if he was to submit the recompiled version it would need a new version number(6 seemed as good a number as any). Maybe 5.11 would be preferred?

@achinault achinault changed the title Update plugin.xml Update plugin.xml for 2017.1 compatibility Apr 4, 2017
@kshchepanovskyi
Copy link

kshchepanovskyi commented Apr 4, 2017

I think your change did not solve an issue, as it was solved before.
Code in this repository contains many fixes since last release in February 2015, and one of them removes usage of some deprecated API (which prevents plugin 0.5.9 from loading).

Probably @tcripps can make a build and upload it to the plugin repository - then problem will be fixed.

However, as an author of https://plugins.jetbrains.com/plugin/8277-protobuf-support, I would like to ask to go in different direction. In comparison to this plugin, I have much better parser, and in general code is easier to extend. There are quite a few features that are missing in my plugin, but present in this one. I would gladly accept PRs for adding missing stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants