cli: Ignore failure when reading /etc/nmstate folder #2283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ffmancera
approved these changes
Mar 21, 2023
cgwalters
reviewed
Mar 21, 2023
| @@ -15,13 +15,23 @@ pub(crate) fn ncl_service( | |||
| .value_of(crate::CONFIG_FOLDER_KEY) | |||
| .unwrap_or(crate::DEFAULT_SERVICE_FOLDER); | |||
|
|
|||
| let config_files = get_config_files(folder)?; | |||
| let config_files = match get_config_files(folder) { | |||
There was a problem hiding this comment.
You might consider using https://crates.io/crates/liboverdrop
When /etc/nmstate not exists or other failure when reading it, we should ignore it and exist 0. Integration test case included. Signed-off-by: Gris Ge <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When /etc/nmstate not exists or other failure when reading it, we should
ignore it and exist 0.
Integration test case included.