Change handler toleration to "operator: exists" #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
|
Hi @cybertron. Thanks for your PR. I'm waiting for a nmstate member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
kubevirt-bot
added
needs-ok-to-test
Since nmstate is to be used for configuration of the network infrastructure, we want the handler to run on all nodes regardless of taint. If a network config should not run on a given node, the NNCP nodeSelector field can be used to accomplish that. For example, a node with a taint of: [map[effect:NoSchedule key:node.ocs.openshift.io/storage value:true]] will currently keep the nmstate handler pod from running there. However, that is not desirable since it prevents the use of nmstate to configure networking on that storage node. This changes the handler toleration to "operator: exists", which will allow the handler to run on all nodes. The webhook toleration is left alone since there is no need for that to be running on nodes with a NoSchedule taint. Signed-off-by: Ben Nemec <[email protected]>
cybertron
force-pushed
the
handler-toleration
branch
from
6f4fd73 to
390ea95
Compare
kubevirt-bot
added
dco-signoff: yes
|
/ok-to-test |
kubevirt-bot
added
ok-to-test
|
/retest I'm not able to see the logs for some reason, so I'm not sure why the jobs failed. e2e tests were working for me locally. |
|
/retest failing test feels related, this was not flaky. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
cybertron
added a commit
to cybertron/kubernetes-nmstate
that referenced
this pull request
Jun 8, 2021
…mstate#755) Since nmstate is to be used for configuration of the network infrastructure, we want the handler to run on all nodes regardless of taint. If a network config should not run on a given node, the NNCP nodeSelector field can be used to accomplish that. For example, a node with a taint of: [map[effect:NoSchedule key:node.ocs.openshift.io/storage value:true]] will currently keep the nmstate handler pod from running there. However, that is not desirable since it prevents the use of nmstate to configure networking on that storage node. This changes the handler toleration to "operator: exists", which will allow the handler to run on all nodes. The webhook toleration is left alone since there is no need for that to be running on nodes with a NoSchedule taint. Signed-off-by: Ben Nemec <[email protected]> (cherry picked from commit b2bccf9)
openshift-cherrypick-robot
pushed a commit
to openshift-cherrypick-robot/kubernetes-nmstate
that referenced
this pull request
Jun 9, 2021
…mstate#755) Since nmstate is to be used for configuration of the network infrastructure, we want the handler to run on all nodes regardless of taint. If a network config should not run on a given node, the NNCP nodeSelector field can be used to accomplish that. For example, a node with a taint of: [map[effect:NoSchedule key:node.ocs.openshift.io/storage value:true]] will currently keep the nmstate handler pod from running there. However, that is not desirable since it prevents the use of nmstate to configure networking on that storage node. This changes the handler toleration to "operator: exists", which will allow the handler to run on all nodes. The webhook toleration is left alone since there is no need for that to be running on nodes with a NoSchedule taint. Signed-off-by: Ben Nemec <[email protected]> (cherry picked from commit b2bccf9)
This was referenced Aug 2, 2021
creydr
pushed a commit
to creydr/kubernetes-nmstate
that referenced
this pull request
Jun 7, 2022
…mstate#755) Since nmstate is to be used for configuration of the network infrastructure, we want the handler to run on all nodes regardless of taint. If a network config should not run on a given node, the NNCP nodeSelector field can be used to accomplish that. For example, a node with a taint of: [map[effect:NoSchedule key:node.ocs.openshift.io/storage value:true]] will currently keep the nmstate handler pod from running there. However, that is not desirable since it prevents the use of nmstate to configure networking on that storage node. This changes the handler toleration to "operator: exists", which will allow the handler to run on all nodes. The webhook toleration is left alone since there is no need for that to be running on nodes with a NoSchedule taint. Signed-off-by: Ben Nemec <[email protected]> (cherry picked from commit b2bccf9) (cherry picked from commit de92fbc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
/kind bug
What this PR does / why we need it:
Since nmstate is to be used for configuration of the network
infrastructure, we want the handler to run on all nodes regardless
of taint. If a network config should not run on a given node, the
NNCP nodeSelector field can be used to accomplish that.
For example, a node with a taint of:
[map[effect:NoSchedule key:node.ocs.openshift.io/storage value:true]]
will currently keep the nmstate handler pod from running there.
However, that is not desirable since it prevents the use of nmstate
to configure networking on that storage node.
This changes the handler toleration to "operator: exists", which
will allow the handler to run on all nodes. The webhook toleration
is left alone since there is no need for that to be running on
nodes with a NoSchedule taint.
Special notes for your reviewer:
Release note: