Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump kube-admission-webhook to 0.15.0 #736

Merged
merged 1 commit into from
Apr 28, 2021
Merged

Bump kube-admission-webhook to 0.15.0 #736

merged 1 commit into from
Apr 28, 2021

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Apr 28, 2021 •
edited
Loading

Is this a BUG FIX or a FEATURE ?:

Uncomment only one, leave it on its own line:

/kind bug
/kind enhancement

What this PR does / why we need it:
Bump kube-admission-webhook to v0.15.0

Special notes for your reviewer:

Release note:

Fix certificate rotation issue related to tls: pub key not matching private key

@kubevirt-bot kubevirt-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Apr 28, 2021
rhrazdil
rhrazdil reviewed Apr 28, 2021
View reviewed changes
Copy link
Collaborator

@rhrazdil rhrazdil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to split to 2 commits? One to remove lockfile and one to bump kaw?

RamLavi
RamLavi approved these changes Apr 28, 2021
View reviewed changes
Copy link
Collaborator

@RamLavi RamLavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2021
@qinqon
Copy link
Member Author

qinqon commented Apr 28, 2021

Would it make sense to split to 2 commits? One to remove lockfile and one to bump kaw?

Is the result of calling make vendor that's why they are in the same commit, I don't htink it's worth it to split it.

@qinqon qinqon requested a review from rhrazdil April 28, 2021 14:33
@rhrazdil
Copy link
Collaborator

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhrazdil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2021
@kubevirt-bot kubevirt-bot merged commit 7bf5d5d into nmstate:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RamLavi RamLavi RamLavi approved these changes

@yboaron yboaron Awaiting requested review from yboaron

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

Assignees

@RamLavi RamLavi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qinqon @rhrazdil @kubevirt-bot @RamLavi