Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup OWNER files #720

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Cleanup OWNER files #720

merged 1 commit into from
Mar 25, 2021

Conversation

qinqon
Copy link
Member

@qinqon qinqon commented Mar 25, 2021 •
edited
Loading

Is this a BUG FIX or a FEATURE ?:
Keep owners we latest review comments.

Uncomment only one, leave it on its own line:

/kind bug
/kind enhancement

What this PR does / why we need it:

Special notes for your reviewer:

Release note:

NONE

@qinqon
Cleanup OWNER files
bc41a3f 
Keep owners we latest review comments.

Signed-off-by: Quique Llorente <[email protected]>
@kubevirt-bot kubevirt-bot added dco-signoff: yes Indicates the PR's author has DCO signed all their commits. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. release-note-none Denotes a PR that doesn't merit a release note. size/XS and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 25, 2021
@qinqon qinqon requested a review from phoracek March 25, 2021 12:11
phoracek
phoracek approved these changes Mar 25, 2021
View reviewed changes
Copy link
Member

@phoracek phoracek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2021
@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: phoracek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2021
@qinqon
Copy link
Member Author

qinqon commented Mar 25, 2021

/override pull-kubernetes-nmstate-e2e-handler-k8s
/override pull-kubernetes-nmstate-e2e-handler-k8s-future
/override pull-kubernetes-nmstate-e2e-handler-k8s-parallel
/override pull-kubernetes-nmstate-e2e-operator-k8s
/override pull-kubernetes-nmstate-docs

@kubevirt-bot
Copy link
Collaborator

@qinqon: Overrode contexts on behalf of qinqon: pull-kubernetes-nmstate-docs, pull-kubernetes-nmstate-e2e-handler-k8s, pull-kubernetes-nmstate-e2e-handler-k8s-future, pull-kubernetes-nmstate-e2e-handler-k8s-parallel, pull-kubernetes-nmstate-e2e-operator-k8s

In response to this:

/override pull-kubernetes-nmstate-e2e-handler-k8s
/override pull-kubernetes-nmstate-e2e-handler-k8s-future
/override pull-kubernetes-nmstate-e2e-handler-k8s-parallel
/override pull-kubernetes-nmstate-e2e-operator-k8s
/override pull-kubernetes-nmstate-docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@qinqon
Copy link
Member Author

qinqon commented Mar 25, 2021

/override pull-kubernetes-nmstate-unit-test

@kubevirt-bot
Copy link
Collaborator

@qinqon: Overrode contexts on behalf of qinqon: pull-kubernetes-nmstate-unit-test

In response to this:

/override pull-kubernetes-nmstate-unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubevirt-bot kubevirt-bot merged commit 08fd191 into nmstate:master Mar 25, 2021
@kubevirt-bot
Copy link
Collaborator

@qinqon: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-nmstate-e2e-handler-k8s-future bc41a3f link /test pull-kubernetes-nmstate-e2e-handler-k8s-future

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phoracek phoracek phoracek approved these changes

@rhrazdil rhrazdil Awaiting requested review from rhrazdil

@yboaron yboaron Awaiting requested review from yboaron

Assignees

@phoracek phoracek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qinqon @kubevirt-bot @phoracek