Consolidate parallel and sequential lanes #717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
release-note
|
cc @qinqon |
rhrazdil
force-pushed
the
consolidate_lanes
branch
4 times, most recently
from
5ae5d75 to
4c4d12c
Compare
rhrazdil
force-pushed
the
consolidate_lanes
branch
5 times, most recently
from
4c4d12c to
cfbd4bb
Compare
added 2 commits
March 25, 2021 13:33
Run the e2e handler test lane only once, configured to use default 50% of worker nodes to process NNCPs concurrently. For that reason, setting number of nodes to 5 so that 2 nodes run concurrently (4/2 == 2) Signed-off-by: Radim Hrazdil <[email protected]>
Now when a failing NNCP is applied, we accept NNCEs in two states: aborted and failed. Signed-off-by: Radim Hrazdil <[email protected]>
rhrazdil
force-pushed
the
consolidate_lanes
branch
from
cfbd4bb to
4e4f9c9
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@rhrazdil: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidate parallel and sequential lanes
Both e2e-handler-k8s-parallel and e2e-handler-k8s lanes run the same tests with
setting maxUnavailable to 50%. After merging this PR, parallel lane can be removed.
This PR increases number of nodes to 5 so that even 50% of the worker nodes yields
2 nodes that can run in parallel.
Signed-off-by: Radim Hrazdil [email protected]
Is this a BUG FIX or a FEATURE ?:
What this PR does / why we need it:
Special notes for your reviewer:
Release note: