Webhookconfig v1 #712
Merged
Webhookconfig v1 #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
dco-signoff: yes
qinqon
force-pushed
the
webhookconfig-v1
branch
2 times, most recently
from
dffed33 to
daca002
Compare
The webhookconfiguration v1alpha1 is going to be deprecated at kubernetes 1.22. This change bumps operator-sdk and kube-admission-webhook to support webhookconfiguration v1 Signed-off-by: Quique Llorente <[email protected]>
After bumping operator-sdk to 1.4.2 the Reconcile function expects a context.Context and the Meta at events is included in the client.Object passed to it. Signed-off-by: Quique Llorente <[email protected]>
After bumping deps some of the .gitignore in the project is making rsync ignore "vendor/github.com/moby/term/.gitignore" and this breaks "make check-gen" Signed-off-by: Quique Llorente <[email protected]>
|
@qinqon: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
kubevirt-bot
added
release-note
|
/lgtm |
rhrazdil
approved these changes
Mar 8, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a BUG FIX or a FEATURE ?:
What this PR does / why we need it:
The webhookconfiguration v1alpha1 is going to be deprecated at
kubernetes 1.22. This change bumps operator-sdk and
kube-admission-webhook to support webhookconfiguration v1
Special notes for your reviewer:
Release note: