Bug 1906198: Accept any name for the nmstate resource #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubevirt-bot
added
the
release-note
kubevirt-bot
added
kind/bug
dco-signoff: yes
qinqon
requested changes
Mar 4, 2021
qinqon
approved these changes
Mar 16, 2021
|
/approve |
kubevirt-bot
added
the
approved
Currently, the operator will only reconcile an nmstate resource that has a name 'nmstate'. This patch makes it possible to add the resource as any name, but subsequent resources added will be ignored. Signed-off-by: Brad P. Crochet <[email protected]>
bcrochet
force-pushed
the
single-nmstate
branch
from
e3b5c60 to
62429e1
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bcrochet: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the operator will only reconcile an nmstate resource that
has a name 'nmstate'. This patch makes it possible to add the resource
as any name, but subsequent resources added will be ignored.
Signed-off-by: Brad P. Crochet [email protected]
Is this a BUG FIX or a FEATURE ?:
/kind bug
What this PR does / why we need it:
Special notes for your reviewer:
Release note: