-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly unmanage veth interfaces #701
Conversation
nmstate 0.3 introduces a bug where all veths attached to nmstatectl configured bridge turn into "managed" by NetworkManager. This was not the case in 0.2. Due to this regression, NetworkManager deliberatelly detaches veth ifaces from the bridge and by doing that it disconnectecs Pods/VMs from the network. With this change, we explicitly set veth interfaces as unmanaged. Important: With this change, it is no longer possible to change configuration of bridges that have veths attached. Signed-off-by: Petr Horáček <[email protected]>
/lgtm Ugly hack that will unblock upgrades, this will be removed after fix at nmstate. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.37 |
@phoracek: once the present PR merges, I will cherry-pick it on top of release-0.37 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
/override pull-kubernetes-nmstate-e2e-handler-k8s-future |
@phoracek: Overrode contexts on behalf of phoracek: pull-kubernetes-nmstate-e2e-handler-k8s-future In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@phoracek: new pull request created: #702 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@phoracek: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This reverts commit f717775.
This reverts commit f717775.
This reverts commit f717775. Signed-off-by: Petr Horáček <[email protected]>
This reverts commit f717775. Signed-off-by: Petr Horáček <[email protected]>
This reverts commit f717775. Signed-off-by: Petr Horáček <[email protected]>
This reverts commit f717775. Signed-off-by: Petr Horáček <[email protected]> Co-authored-by: Petr Horáček <[email protected]>
Is this a BUG FIX or a FEATURE ?:
/kind bug
What this PR does / why we need it:
nmstate 0.3 introduces a bug where all veths attached to nmstatectl
configured bridge turn into "managed" by NetworkManager. This was not
the case in 0.2.
Due to this regression, NetworkManager deliberatelly detaches veth
ifaces from the bridge and by doing that it disconnectecs Pods/VMs from
the network.
With this change, we explicitly set veth interfaces as unmanaged.
Important: With this change, it is no longer possible to change
configuration of bridges that have veths attached.
This should be reverted once https://bugzilla.redhat.com/show_bug.cgi?id=1932247 becomes available.
Special notes for your reviewer:
Release note: